* Re: [rfa/copyright] add copyrights to gdb.mi/pthreads.c, gdb.threads/pthreads.c
@ 2003-10-23 4:08 Michael Elizabeth Chastain
2003-10-23 4:21 ` Andrew Cagney
0 siblings, 1 reply; 5+ messages in thread
From: Michael Elizabeth Chastain @ 2003-10-23 4:08 UTC (permalink / raw)
To: ac131313; +Cc: cagney, ezannoni, gdb-patches, msnyder
Okay, here is another version of gdb.threads/pthreads.c.
I'll focus on this file first.
I can almost see daylight from here ...
ac> Mention that it was written by Fred Fish, and contributed by Red Hat.
I wrote:
Written by Fred Fish of Cygnus Support.
Contributed by Cygnus Support.
It was "Cygnus Support" in 1996. Is that okay?
Or tell me again if you explicitly want either of these "Cygnus Support"
lines to say "Red Hat". The ways of legalese are arcane.
ac> I've attached the "prehistory" of pthreads.c. Did you need more?
Yes, can you send me the whole cygnus "cvs log" for this file.
Or was that the whole log?
Were there any changes in 1997, 1998?
I can take care of browsing through gdb-*.tar.gz and figuring out
the test for "each year in which you finished preparing a version
which was actually released, and which was an ancestor of the
current version".
ac> ... I'm not sure which of the below dates should be listed.
All those dates are in 1996 so I used 1996. I'm so glad that
copyright notices have a resolution of "year", and not "month/year".
ac> Also use the src/gdb/*.c boilerplate copyright style.
ac> And state that it is part of GDB (rather than the GDB testsuite).
Done.
Here's what it looks like now ... pending "Cygnus" vs "Red Hat"
and "1997? 1998?".
Michael C
===
2003-10-22 Michael Chastain <mec@shout.net>
* gdb.threads/pthreads.c: Add copyright notice.
Index: pthreads.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/pthreads.c,v
retrieving revision 1.4
diff -c -3 -p -r1.4 pthreads.c
*** pthreads.c 7 Aug 2003 17:48:32 -0000 1.4
--- pthreads.c 23 Oct 2003 03:43:53 -0000
***************
*** 1,3 ****
--- 1,27 ----
+ /* Pthreads test program.
+ Copyright 1996, 1999, 2002, 2003
+ Free Software Foundation, Inc.
+
+ Written by Fred Fish of Cygnus Support.
+ Contributed by Cygnus Support.
+
+ This file is part of GDB.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 59 Temple Place - Suite 330,
+ Boston, MA 02111-1307, USA. */
+
#include <stdio.h>
#include <pthread.h>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [rfa/copyright] add copyrights to gdb.mi/pthreads.c, gdb.threads/pthreads.c
2003-10-23 4:08 [rfa/copyright] add copyrights to gdb.mi/pthreads.c, gdb.threads/pthreads.c Michael Elizabeth Chastain
@ 2003-10-23 4:21 ` Andrew Cagney
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Cagney @ 2003-10-23 4:21 UTC (permalink / raw)
To: Michael Elizabeth Chastain
Cc: ac131313, cagney, ezannoni, gdb-patches, msnyder
> Okay, here is another version of gdb.threads/pthreads.c.
> I'll focus on this file first.
>
> I can almost see daylight from here ...
>
> ac> Mention that it was written by Fred Fish, and contributed by Red Hat.
>
> I wrote:
>
> Written by Fred Fish of Cygnus Support.
> Contributed by Cygnus Support.
>
> It was "Cygnus Support" in 1996. Is that okay?
M'kay.
> Yes, can you send me the whole cygnus "cvs log" for this file.
> Or was that the whole log?
>
> Were there any changes in 1997, 1998?
That is the whole log! Everything else is external.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [rfa/copyright] add copyrights to gdb.mi/pthreads.c, gdb.threads/pthreads.c
@ 2003-10-23 4:27 Michael Elizabeth Chastain
0 siblings, 0 replies; 5+ messages in thread
From: Michael Elizabeth Chastain @ 2003-10-23 4:27 UTC (permalink / raw)
To: ac131313; +Cc: cagney, ezannoni, gdb-patches, msnyder
mec> Were there any changes in 1997, 1998?
ac> That is the whole log! Everything else is external.
That's great! Then I will commit my patch shortly.
I am double-checking on 1999. It seems that the contents did not
change at all in 1999, just the timestamp, because of the
repository change. So I might take 1999 out of the list.
Michael C
^ permalink raw reply [flat|nested] 5+ messages in thread
* [rfa/copyright] add copyrights to gdb.mi/pthreads.c, gdb.threads/pthreads.c
@ 2003-10-21 18:49 Michael Elizabeth Chastain
2003-10-23 2:44 ` Andrew Cagney
0 siblings, 1 reply; 5+ messages in thread
From: Michael Elizabeth Chastain @ 2003-10-21 18:49 UTC (permalink / raw)
To: cagney, ezannoni, msnyder; +Cc: gdb-patches
This patch adds copyright notices to testsuite/gdb.threads/pthreads.c
and testsuite/gdb.mi/pthreads.c, in accordance with FSF policy:
http://www.gnu.org/prep/maintain_8.html#SEC8
(I want to do this because I have additional changes for pthreads.c.
I want to change the "sleep" calls to check the return value so
that they work properly with gdb. There is a known issue with
calling "sleep" in a multi-threaded program under gdb -- the "sleep"
often returns early, which is legal, but is different behavior
than non-gdb. But even if my additional changes are not accepted,
these files still need copyright notices. That's why I am submitting
this patch first.)
History of these files: gdb.threads/pthreads.c was the original file.
It was created by shebs, and edited by chastain, cagney, ezannoni,
and carlton. gdb.mi/pthreads.c was cloned from gdb.threads/pthreads.c
by kseitz, and was edited by kseitz, carlton, and ezannoni.
All of these people have gdb assignments on file and have made
many other contributions to gdb.
Testing: tested on native i686-pc-linux-gnu, red hat 8.0,
gcc v2 and v3, dwarf-2 and stabs+, just to make sure that
I didn't break some line number dependency in some *.exp file.
Michael S is the maintainer for gdb.threads.
Elena and Andrew are maintainers for gdb.mi.
Okay to commit?
Michael C
===
2003-10-21 Michael Chastain <mec@shout.net>
* gdb.mi/pthreads.c: Add copyright notice.
* gdb.threads/pthreads.c: Add copyright notice.
Index: gdb.mi/pthreads.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/pthreads.c,v
retrieving revision 1.3
diff -c -3 -p -r1.3 pthreads.c
*** gdb.mi/pthreads.c 7 Aug 2003 17:48:32 -0000 1.3
--- gdb.mi/pthreads.c 21 Oct 2003 16:58:31 -0000
***************
*** 1,3 ****
--- 1,24 ----
+ /* Copyright 2002, 2003 Free Software Foundation, Inc.
+
+ This file is part of the gdb testsuite.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+
+ This file was copied from gdb.threads/pthreads.c
+ by Keith Seitz (keiths@redhat.com). */
+
#include <stdio.h>
#include <pthread.h>
Index: gdb.threads/pthreads.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/pthreads.c,v
retrieving revision 1.4
diff -c -3 -p -r1.4 pthreads.c
*** gdb.threads/pthreads.c 7 Aug 2003 17:48:32 -0000 1.4
--- gdb.threads/pthreads.c 21 Oct 2003 16:58:31 -0000
***************
*** 1,3 ****
--- 1,22 ----
+ /* Copyright 1999, 2002, 2003 Free Software Foundation, Inc.
+
+ This file is part of the gdb testsuite.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ */
+
#include <stdio.h>
#include <pthread.h>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [rfa/copyright] add copyrights to gdb.mi/pthreads.c, gdb.threads/pthreads.c
2003-10-21 18:49 Michael Elizabeth Chastain
@ 2003-10-23 2:44 ` Andrew Cagney
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Cagney @ 2003-10-23 2:44 UTC (permalink / raw)
To: Michael Elizabeth Chastain; +Cc: cagney, ezannoni, msnyder, gdb-patches
> This patch adds copyright notices to testsuite/gdb.threads/pthreads.c
> and testsuite/gdb.mi/pthreads.c, in accordance with FSF policy:
>
> http://www.gnu.org/prep/maintain_8.html#SEC8
Tell me about it. I'm up to lawyer number 12 ...
I've attached the "prehistory" of pthreads.c. Did you need more?
Mention that it was written by fred fish, and contributed by red hat.
I'm not a lawyer so I'm not sure which of the below dates should be
listed (so list all of them :-).
Also use the src/gdb/*.c boilerplate copyright style. And state that it
is part of GDB (rather than the GDB testsuite).
Otherwize "obvious".
Andrew
revision 1.4
date: 1996/11/23 21:33:15; author: fnf; state: Exp; lines: +4 -0
branches: 1.4.562; 1.4.674;
* gdb.base/a1-selftest.exp: Change x86 linux setup_xfails to
use new i*86-pc-linux*-gnu quads.
* gdb.base/corefile.exp: Ditto.
* gdb.base/signals.exp: Ditto.
* gdb.base/sigall.exp: Ditto.
* gdb.base/interrupt.exp: Ditto.
* gdb.base/signals.exp (signal_tests_1): Remove setup_xfail
"i*86-*-linux" for "signal SIGUSR1". Now works, at least with
RedHat 4.0.
* gdb.threads/pthreads.c (_MIT_POSIX_THREADS): Define if target is
linux. This allows the test case to at least compile on latest
linux, but still not run due to missing the threads runtime
library.
----------------------------
revision 1.3
date: 1996/09/03 01:26:44; author: fnf; state: Exp; lines: +4 -4
* gdb.base/break.exp: Expand "Delete all breakpoints" xfail to
include all osf versions.
* gdb.threads/pthreads.exp: Expand "run to main" xfail to include
all osf versions. Add -D_MIT_POSIX_THREADS to compilation command
when target is linux. When failing to build pthreads test
executable, give more meaningful message.
* gdb.threads/pthreads.c: Hpux also uses old definition of second
arg for pthread_create.
----------------------------
revision 1.2
date: 1996/08/19 17:59:46; author: fnf; state: Exp; lines: +18 -3
* gdb.threads/pthreads.c (PTHREAD_CREATE_ARG2,
PTHREAD_CREATE_NULL_ARG2): Accomodate old pthreads implementations.
* gdb.threads/pthreads.exp: Try linking with both -lpthread
(Solaris)
and -lpthreads (everybody else).
(test_startup): Fail gracefully if threads are not supported.
* gdb.base/nodebug.exp: Add setup_xfail hppa*-*-hpux* for
"p/c array_index("abcdef",2)" when not gcc compiled.
* gdb.base/corefile.exp: Add setup_xfail hppa*-*-hpux* for
"print func2::coremaker_local" when not gcc compiled.
* gdb.base/opaque.exp: Remove setup_xfail hppa*-*-hpux* for
"ptype on opaque struct tagname (statically)",
"ptype on opaque struct tagname (dynamically) 1", and
"ptype on opaque struct tagname (dynamically) 2"
for not compiled with gcc.
* gdb.base/mips_pro.exp: Only do setup_xfail hppa*-*-* for
backtrace when compiled with gcc.
* lib/gdb.exp (runto_main): Return result of "runto main" rather
than always return success.
----------------------------
revision 1.1
date: 1996/08/07 18:14:55; author: fnf; state: Exp;
* configure.in (configdirs): Add gdb.threads.
* configure: Regenerated with autoconf.
* gdb.threads/{config.in, pthreads.c, pthreads.exp}: New.
:
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-10-23 4:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-23 4:08 [rfa/copyright] add copyrights to gdb.mi/pthreads.c, gdb.threads/pthreads.c Michael Elizabeth Chastain
2003-10-23 4:21 ` Andrew Cagney
-- strict thread matches above, loose matches on Subject: below --
2003-10-23 4:27 Michael Elizabeth Chastain
2003-10-21 18:49 Michael Elizabeth Chastain
2003-10-23 2:44 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox