Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [BFD PATCH] section alignment when reading core files
@ 2003-10-16 18:40 Roland McGrath
  2003-10-16 18:51 ` H. J. Lu
  0 siblings, 1 reply; 3+ messages in thread
From: Roland McGrath @ 2003-10-16 18:40 UTC (permalink / raw)
  To: binutils; +Cc: gdb-patches

Can I get some comment on this trivial patch?  I posted it before, and silence.
It is trivial, and I think obviously correct.

Ok to commit?


Thanks,
Roland


2003-10-07  Roland McGrath  <roland@redhat.com>

	* elf.c (_bfd_elf_make_section_from_phdr): Set alignment_power of
	new section from p_align header field.

Index: elf.c
===================================================================
RCS file: /cvs/src/src/bfd/elf.c,v
retrieving revision 1.201
diff -u -b -p -r1.201 elf.c
--- elf.c	16 Oct 2003 04:11:05 -0000	1.201
+++ elf.c	16 Oct 2003 18:38:48 -0000
@@ -2206,6 +2206,7 @@ _bfd_elf_make_section_from_phdr (bfd *ab
   newsect->_raw_size = hdr->p_filesz;
   newsect->filepos = hdr->p_offset;
   newsect->flags |= SEC_HAS_CONTENTS;
+  newsect->alignment_power = bfd_log2 (hdr->p_align);
   if (hdr->p_type == PT_LOAD)
     {
       newsect->flags |= SEC_ALLOC;


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BFD PATCH] section alignment when reading core files
  2003-10-16 18:40 [BFD PATCH] section alignment when reading core files Roland McGrath
@ 2003-10-16 18:51 ` H. J. Lu
  2003-10-16 18:54   ` Roland McGrath
  0 siblings, 1 reply; 3+ messages in thread
From: H. J. Lu @ 2003-10-16 18:51 UTC (permalink / raw)
  To: Roland McGrath; +Cc: binutils, gdb-patches

On Thu, Oct 16, 2003 at 11:40:50AM -0700, Roland McGrath wrote:
> Can I get some comment on this trivial patch?  I posted it before, and silence.
> It is trivial, and I think obviously correct.
> 
> Ok to commit?
> 
> 

Isn't Alan OKed it?

http://sources.redhat.com/ml/binutils/2003-10/msg00162.html


H.J.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BFD PATCH] section alignment when reading core files
  2003-10-16 18:51 ` H. J. Lu
@ 2003-10-16 18:54   ` Roland McGrath
  0 siblings, 0 replies; 3+ messages in thread
From: Roland McGrath @ 2003-10-16 18:54 UTC (permalink / raw)
  To: H. J. Lu; +Cc: binutils, gdb-patches

> Isn't Alan OKed it?
> 
> http://sources.redhat.com/ml/binutils/2003-10/msg00162.html

Oops!  Somehow I missed that message.  Thanks.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-10-16 18:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-16 18:40 [BFD PATCH] section alignment when reading core files Roland McGrath
2003-10-16 18:51 ` H. J. Lu
2003-10-16 18:54   ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox