Re: [RFA] New baseboard file sh-sim.exp

Re: [RFA] New baseboard file sh-sim.exp

[Michael Elizabeth Chastain]

I think this file needs a copyright notice.

There are some files, especially auxiliary files like test suite files,
that do not have any copyright notice in them.  :(  You are stepping
into an existing problem, but could you put a standard copyright
notice on the new files at least?

Michael C

===

ChangeLog:

	* baseboards/sh-sim.exp: New file.

Re: [RFA] New baseboard file sh-sim.exp

[Corinna Vinschen]

On Mon, Oct 13, 2003 at 01:10:37PM -0400, Michael Elizabeth Chastain wrote:
> I think this file needs a copyright notice.

None of the baseboard files have a copyright notice, actually.

Corinna

> 	* baseboards/sh-sim.exp: New file.

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.

Re: [RFA] New baseboard file sh-sim.exp

[Michael Elizabeth Chastain]

cv> The answer I got from Ben is that "... all DejaGnu source files have the
cv> FSF copyright header now as part of a recent source clean-up."

Yay!  The swamp is draining, bit by bit!
  
Michael C

===

	* baseboards/sh-sim.exp: Add copyright header.

Re: [RFA] New baseboard file sh-sim.exp

[Michael Elizabeth Chastain]

mec> I think this file needs a copyright notice.
cv> None of the baseboard files have a copyright notice, actually.

Both of these things are true.  :(

It's FSF policy to include copyright notices in files such as
the baseboard files.

  http://www.gnu.org/prep/maintain_8.html#SEC8

But I don't like dependencies where new work is required to fix existing
bugs before the new work can go in.  So, I won't object, but I will moan
and whine.

It's a hard problem.

Michael C

Re: [RFA] New baseboard file sh-sim.exp

[Elena Zannoni]

Michael Elizabeth Chastain writes:
 > mec> I think this file needs a copyright notice.
 > cv> None of the baseboard files have a copyright notice, actually.
 > 
 > Both of these things are true.  :(
 > 
 > It's FSF policy to include copyright notices in files such as
 > the baseboard files.
 > 
 >   http://www.gnu.org/prep/maintain_8.html#SEC8
 > 
 > But I don't like dependencies where new work is required to fix existing
 > bugs before the new work can go in.  So, I won't object, but I will moan
 > and whine.
 > 
 > It's a hard problem.
 > 
 > Michael C

I think adding the (C) notice to just this file is a start and an
acceptable compromise. Asking to add it to all would definitely be too
much.

elena

Re: [RFA] New baseboard file sh-sim.exp

[Corinna Vinschen]

On Tue, Oct 14, 2003 at 02:07:43PM -0400, Elena Zannoni wrote:
> Michael Elizabeth Chastain writes:
>  > mec> I think this file needs a copyright notice.
>  > cv> None of the baseboard files have a copyright notice, actually.
>  > 
>  > Both of these things are true.  :(
>  > 
>  > It's FSF policy to include copyright notices in files such as
>  > the baseboard files.
>  > 
>  >   http://www.gnu.org/prep/maintain_8.html#SEC8
>  > 
>  > But I don't like dependencies where new work is required to fix existing
>  > bugs before the new work can go in.  So, I won't object, but I will moan
>  > and whine.
>  > 
>  > It's a hard problem.
>  > 
>  > Michael C
> 
> I think adding the (C) notice to just this file is a start and an
> acceptable compromise. Asking to add it to all would definitely be too
> much.

I've asked Ben Elliston how the dejagnu maintainers want to handle this,
given the http://www.gnu.org/prep/maintain_8.html#SEC8 section.  I'll
forward the reply when I get it.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.

Re: [RFA] New baseboard file sh-sim.exp

[Corinna Vinschen]

On Tue, Oct 14, 2003 at 08:48:22PM +0200, Corinna Vinschen wrote:
> On Tue, Oct 14, 2003 at 02:07:43PM -0400, Elena Zannoni wrote:
> > Michael Elizabeth Chastain writes:
> >  > mec> I think this file needs a copyright notice.
> >  > cv> None of the baseboard files have a copyright notice, actually.
> >  > [...]
> > I think adding the (C) notice to just this file is a start and an
> > acceptable compromise. Asking to add it to all would definitely be too
> > much.
> 
> I've asked Ben Elliston how the dejagnu maintainers want to handle this,
> given the http://www.gnu.org/prep/maintain_8.html#SEC8 section.  I'll
> forward the reply when I get it.

The answer I got from Ben is that "... all DejaGnu source files have the
FSF copyright header now as part of a recent source clean-up."

Ben has sent me the sh-sim.exp file as he has applied it to the DejaGnu
repository.  I've checked it in to our dejagnu/baseboard directory.

Corinna

	* baseboards/sh-sim.exp: Add copyright header.

Index: baseboards/sh-sim.exp
===================================================================
RCS file: /cvs/src/src/dejagnu/baseboards/sh-sim.exp,v
retrieving revision 1.1
diff -u -p -r1.1 sh-sim.exp
--- baseboards/sh-sim.exp       13 Oct 2003 09:17:25 -0000      1.1
+++ baseboards/sh-sim.exp       15 Oct 2003 09:37:25 -0000
@@ -1,3 +1,21 @@
+# Copyright (C) 2003 Free Software Foundation, Inc.
+#
+# This file is part of DejaGnu.
+#
+# DejaGnu is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# DejaGnu is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with DejaGnu; if not, write to the Free Software Foundation,
+# Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+
 # This is a list of toolchains that are supported on this board.
 set_board_info target_install {sh-elf}
 
@@ -45,4 +63,3 @@ set_board_info gdb,skip_huge_test 1
 
 # Nor are interrupts really working.
 set_board_info gdb,nointerrupts 1
-

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.

[RFA] New baseboard file sh-sim.exp

[Corinna Vinschen]

Hi,

the below file is a new version of a baseboard file for the SH
simulator, rewritten by Michael Snyder.  It takes the new capabilities
of the simulator into account and it drops the unnecessary -hms from
the name. 

Corinna

ChangeLog:

	* baseboards/sh-sim.exp: New file.

Index: baseboards/sh-sim.exp
===================================================================
RCS file: baseboards/sh-sim.exp
diff -N baseboards/sh-sim.exp
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ baseboards/sh-sim.exp	9 Oct 2003 16:54:27 -0000
@@ -0,0 +1,48 @@
+# This is a list of toolchains that are supported on this board.
+set_board_info target_install {sh-elf}
+
+# Load the generic configuration for this board. This will define a basic set
+# of routines needed by the tool to communicate with the board.
+load_generic_config "sim"
+
+# basic-sim.exp is a basic description for the standard Cygnus simulator.
+load_base_board_description "basic-sim"
+
+# "sh" is the name of the sim subdir in devo/sim.
+setup_sim sh
+
+# No multilib options needed by default.
+process_multilib_options ""
+
+# We only support newlib on this target. We assume that all multilib
+# options have been specified before we get here.
+
+set_board_info compiler  "[find_gcc]"
+set_board_info cflags    "[libgloss_include_flags] [newlib_include_flags]"
+set_board_info ldflags   "[libgloss_link_flags] [newlib_link_flags]"
+# No linker script needed.
+set_board_info ldscript "";
+
+verbose "Using simulator [board_info $board sim]\n"
+
+# Prints to stdout OK.
+# Returns exit status OK (does not need status wrapper).
+# Passes argc, argv OK.
+# Calls functions OK.
+
+# No signals.
+set_board_info gdb,nosignals 1
+
+# Used by a few gcc.c-torture testcases to delimit how large the stack
+# can be.
+set_board_info gcc,stack_size 16384
+
+# Need to pass -mieee in order to for the compiler to be IEEE-fp compliant.
+set_board_info ieee_multilib_flags "-mieee";
+
+# Small memory, can't do gdb's "huge.exp" test.
+set_board_info gdb,skip_huge_test 1
+
+# Nor are interrupts really working.
+set_board_info gdb,nointerrupts 1
+

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.

Re: [RFA] New baseboard file sh-sim.exp

[Ben Elliston]

Corinna Vinschen <vinschen@redhat.com> writes:

> the below file is a new version of a baseboard file for the SH
> simulator, rewritten by Michael Snyder.  It takes the new
> capabilities of the simulator into account and it drops the
> unnecessary -hms from the name.

Are you proposing that baseboards/sh-hms.exp be removed as well?

The patch looks okay, except for the unnecessary use of semicolons at
the end of lines.

Ben

Re: [RFA] New baseboard file sh-sim.exp

[Corinna Vinschen]

Hi Ben,

On Fri, Oct 10, 2003 at 09:36:05AM +1000, Ben Elliston wrote:
> Corinna Vinschen <vinschen@redhat.com> writes:
> 
> > the below file is a new version of a baseboard file for the SH
> > simulator, rewritten by Michael Snyder.  It takes the new
> > capabilities of the simulator into account and it drops the
> > unnecessary -hms from the name.
> 
> Are you proposing that baseboards/sh-hms.exp be removed as well?

erm... actually I had written the mail so that it also proposed to
remove sh-hms-sim.exp.  But I wasn't quite sure if there's anybody
out there who might rely on the diffences, so I removed that part
from my mail again.

But, yes, IMHO, the sh-sim.exp supersedes sh-hms.sim.exp entirely.
I think we can remove it.

> The patch looks okay, except for the unnecessary use of semicolons at
> the end of lines.

Hey, that's just in two lines ;-)  But I'll change that for the
gdb repository, if the new file gets approved.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.

Re: [RFA] New baseboard file sh-sim.exp

[Elena Zannoni]

Corinna Vinschen writes:
 > Hi,
 > 
 > the below file is a new version of a baseboard file for the SH
 > simulator, rewritten by Michael Snyder.  It takes the new capabilities
 > of the simulator into account and it drops the unnecessary -hms from
 > the name. 
 > 

Yes, the sh-hms target was removed from gdb. 
Not sure who's approving these. But Ok from me.

See below for a couple of comments.

elena


 > Corinna
 > 
 > ChangeLog:
 > 
 > 	* baseboards/sh-sim.exp: New file.
 > 
 > Index: baseboards/sh-sim.exp
 > ===================================================================
 > RCS file: baseboards/sh-sim.exp
 > diff -N baseboards/sh-sim.exp
 > --- /dev/null	1 Jan 1970 00:00:00 -0000
 > +++ baseboards/sh-sim.exp	9 Oct 2003 16:54:27 -0000
 > @@ -0,0 +1,48 @@
 > +# This is a list of toolchains that are supported on this board.
 > +set_board_info target_install {sh-elf}
 > +
 > +# Load the generic configuration for this board. This will define a basic set
 > +# of routines needed by the tool to communicate with the board.
 > +load_generic_config "sim"
 > +
 > +# basic-sim.exp is a basic description for the standard Cygnus simulator.

Cygnus reference should go.

 > +load_base_board_description "basic-sim"
 > +
 > +# "sh" is the name of the sim subdir in devo/sim.

this one too. 

 > +setup_sim sh
 > +
 > +# No multilib options needed by default.
 > +process_multilib_options ""
 > +
 > +# We only support newlib on this target. We assume that all multilib
 > +# options have been specified before we get here.
 > +
 > +set_board_info compiler  "[find_gcc]"
 > +set_board_info cflags    "[libgloss_include_flags] [newlib_include_flags]"
 > +set_board_info ldflags   "[libgloss_link_flags] [newlib_link_flags]"
 > +# No linker script needed.
 > +set_board_info ldscript "";
 > +
 > +verbose "Using simulator [board_info $board sim]\n"
 > +
 > +# Prints to stdout OK.
 > +# Returns exit status OK (does not need status wrapper).
 > +# Passes argc, argv OK.
 > +# Calls functions OK.
 > +
 > +# No signals.
 > +set_board_info gdb,nosignals 1
 > +
 > +# Used by a few gcc.c-torture testcases to delimit how large the stack
 > +# can be.
 > +set_board_info gcc,stack_size 16384
 > +
 > +# Need to pass -mieee in order to for the compiler to be IEEE-fp compliant.
 > +set_board_info ieee_multilib_flags "-mieee";
 > +
 > +# Small memory, can't do gdb's "huge.exp" test.
 > +set_board_info gdb,skip_huge_test 1
 > +
 > +# Nor are interrupts really working.
 > +set_board_info gdb,nointerrupts 1
 > +
 > 
 > -- 
 > Corinna Vinschen
 > Cygwin Developer
 > Red Hat, Inc.

Re: [RFA] New baseboard file sh-sim.exp

[Corinna Vinschen]

On Fri, Oct 10, 2003 at 02:22:24PM -0400, Elena Zannoni wrote:
> Corinna Vinschen writes:
>  > Hi,
>  > 
>  > the below file is a new version of a baseboard file for the SH
>  > simulator, rewritten by Michael Snyder.  It takes the new capabilities
>  > of the simulator into account and it drops the unnecessary -hms from
>  > the name. 
>  > 
> 
> Yes, the sh-hms target was removed from gdb. 
> Not sure who's approving these. But Ok from me.
> 
> See below for a couple of comments.

Applied with appropriate changes (dropped "Cygnus" and " in devo/sim"
from comments, removed the unnecessary semicolons), see below.

I didn't remove sh-hms-sim.exp so far.  If that's ok with the dejagnu
developers, I'll remove it from the gdb repository.

Corinna

ChangeLog:

	* baseboards/sh-sim.exp: New file.

--- /dev/null	2003-03-14 14:07:09.000000000 +0100
+++ baseboards/sh-sim.exp	2003-10-13 11:16:26.000000000 +0200
@@ -0,0 +1,48 @@
+# This is a list of toolchains that are supported on this board.
+set_board_info target_install {sh-elf}
+
+# Load the generic configuration for this board. This will define a basic set
+# of routines needed by the tool to communicate with the board.
+load_generic_config "sim"
+
+# basic-sim.exp is a basic description for the standard simulator.
+load_base_board_description "basic-sim"
+
+# "sh" is the name of the sim subdir.
+setup_sim sh
+
+# No multilib options needed by default.
+process_multilib_options ""
+
+# We only support newlib on this target. We assume that all multilib
+# options have been specified before we get here.
+
+set_board_info compiler  "[find_gcc]"
+set_board_info cflags    "[libgloss_include_flags] [newlib_include_flags]"
+set_board_info ldflags   "[libgloss_link_flags] [newlib_link_flags]"
+# No linker script needed.
+set_board_info ldscript ""
+
+verbose "Using simulator [board_info $board sim]\n"
+
+# Prints to stdout OK.
+# Returns exit status OK (does not need status wrapper).
+# Passes argc, argv OK.
+# Calls functions OK.
+
+# No signals.
+set_board_info gdb,nosignals 1
+
+# Used by a few gcc.c-torture testcases to delimit how large the stack
+# can be.
+set_board_info gcc,stack_size 16384
+
+# Need to pass -mieee in order to for the compiler to be IEEE-fp compliant.
+set_board_info ieee_multilib_flags "-mieee"
+
+# Small memory, can't do gdb's "huge.exp" test.
+set_board_info gdb,skip_huge_test 1
+
+# Nor are interrupts really working.
+set_board_info gdb,nointerrupts 1
+

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.

Re: [RFA] New baseboard file sh-sim.exp

[Ben Elliston]

Corinna Vinschen <vinschen@redhat.com> writes:

> Applied with appropriate changes (dropped "Cygnus" and " in devo/sim"
> from comments, removed the unnecessary semicolons), see below.

Thanks. I checked in your new file.

> I didn't remove sh-hms-sim.exp so far.  If that's ok with the
> dejagnu developers, I'll remove it from the gdb repository.

Probably just best to wait for the next DejaGnu release, which isn't
too far off.

Ben