Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Elizabeth Chastain <mec@shout.net>
To: ezannoni@redhat.com, gdb-patches@sources.redhat.com, vinschen@redhat.com
Subject: Re: [RFA] gdb.base/call-rt-st.*: Add char bitfield and short bitfield tests
Date: Sat, 11 Oct 2003 21:26:00 -0000	[thread overview]
Message-ID: <200310112126.h9BLQHa1022798@duracef.shout.net> (raw)

I proofread the patch and found one copy-and-paste glitch:

    if ![gdb_skip_stdio_test "print print_bit_flags_short(*flags)"] {
	print_struct_call "print_bit_flags(*flags)" \
		".*alpha\[ \r\n\]+gamma\[ \r\n\]+epsilon\[ \r\n\]+.\[0-9\]+ = \\{alpha = 1, beta = 0, gamma = 1, delta = 0, epsilon = 1, omega = 0\\}"
    }

The second line should be "print_struct_call print_bit_flags_short".

My test bed likes this patch.

Recommended for approval, with this change.

Michael C

===

	* gdb.base/call-rt-st.c (struct bit_flags_char_t): New bitfield
	type, based on char type.
	(struct bit_flags_short_t): New bitfield type, based on short type.
	(init_bit_flags_char): New fuction.
	(init_bit_flags_short): Ditto.
	(print_bit_flags_char): Ditto.
	(print_bit_flags_short): Ditto.
	(main): Add handling for bit_flags_char_t and bit_flags_short_t.


             reply	other threads:[~2003-10-11 21:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-11 21:26 Michael Elizabeth Chastain [this message]
2003-10-13  9:14 ` Corinna Vinschen
  -- strict thread matches above, loose matches on Subject: below --
2003-10-10 17:18 Corinna Vinschen
2003-10-10 17:59 ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200310112126.h9BLQHa1022798@duracef.shout.net \
    --to=mec@shout.net \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vinschen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox