From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-27856-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 22456 invoked by alias); 11 Oct 2003 21:26:19 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 22449 invoked from network); 11 Oct 2003 21:26:18 -0000
Received: from unknown (HELO concert.shout.net) (204.253.184.25)
  by sources.redhat.com with SMTP; 11 Oct 2003 21:26:18 -0000
Received: from duracef.shout.net (duracef.shout.net [204.253.184.12])
	by concert.shout.net (8.12.10/8.12.10) with ESMTP id h9BLQHqs028892;
	Sat, 11 Oct 2003 16:26:17 -0500
Received: from duracef.shout.net (localhost [127.0.0.1])
	by duracef.shout.net (8.12.10/8.12.9) with ESMTP id h9BLQHVd022799;
	Sat, 11 Oct 2003 16:26:17 -0500
Received: (from mec@localhost)
	by duracef.shout.net (8.12.10/8.12.9/Submit) id h9BLQHa1022798;
	Sat, 11 Oct 2003 17:26:17 -0400
Date: Sat, 11 Oct 2003 21:26:00 -0000
From: Michael Elizabeth Chastain <mec@shout.net>
Message-Id: <200310112126.h9BLQHa1022798@duracef.shout.net>
To: ezannoni@redhat.com, gdb-patches@sources.redhat.com, vinschen@redhat.com
Subject: Re: [RFA] gdb.base/call-rt-st.*: Add char bitfield and short bitfield tests
X-SW-Source: 2003-10/txt/msg00417.txt.bz2

I proofread the patch and found one copy-and-paste glitch:

    if ![gdb_skip_stdio_test "print print_bit_flags_short(*flags)"] {
	print_struct_call "print_bit_flags(*flags)" \
		".*alpha\[ \r\n\]+gamma\[ \r\n\]+epsilon\[ \r\n\]+.\[0-9\]+ = \\{alpha = 1, beta = 0, gamma = 1, delta = 0, epsilon = 1, omega = 0\\}"
    }

The second line should be "print_struct_call print_bit_flags_short".

My test bed likes this patch.

Recommended for approval, with this change.

Michael C

===

	* gdb.base/call-rt-st.c (struct bit_flags_char_t): New bitfield
	type, based on char type.
	(struct bit_flags_short_t): New bitfield type, based on short type.
	(init_bit_flags_char): New fuction.
	(init_bit_flags_short): Ditto.
	(print_bit_flags_char): Ditto.
	(print_bit_flags_short): Ditto.
	(main): Add handling for bit_flags_char_t and bit_flags_short_t.