* Re: [RFA] testsuite/gdb.base/ending-run.exp: Add sh specific case
@ 2003-10-03 15:22 Michael Elizabeth Chastain
2003-10-04 12:23 ` Corinna Vinschen
0 siblings, 1 reply; 6+ messages in thread
From: Michael Elizabeth Chastain @ 2003-10-03 15:22 UTC (permalink / raw)
To: gdb-patches
Proofread, but not tested.
Looks fine to me, as long as you say that you've tested it.
I don't have approval authority.
Michael C
===
Corinna
* gdb.base/ending-run.exp: Add sh specific case.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] testsuite/gdb.base/ending-run.exp: Add sh specific case
2003-10-03 15:22 [RFA] testsuite/gdb.base/ending-run.exp: Add sh specific case Michael Elizabeth Chastain
@ 2003-10-04 12:23 ` Corinna Vinschen
2003-10-07 14:55 ` Corinna Vinschen
0 siblings, 1 reply; 6+ messages in thread
From: Corinna Vinschen @ 2003-10-04 12:23 UTC (permalink / raw)
To: gdb-patches
On Fri, Oct 03, 2003 at 11:22:18AM -0400, Michael Elizabeth Chastain wrote:
> Proofread, but not tested.
>
> Looks fine to me, as long as you say that you've tested it.
Yes, it is tested.
Corinna
> I don't have approval authority.
>
> Michael C
>
> ===
>
> Corinna
>
> * gdb.base/ending-run.exp: Add sh specific case.
--
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] testsuite/gdb.base/ending-run.exp: Add sh specific case
2003-10-04 12:23 ` Corinna Vinschen
@ 2003-10-07 14:55 ` Corinna Vinschen
0 siblings, 0 replies; 6+ messages in thread
From: Corinna Vinschen @ 2003-10-07 14:55 UTC (permalink / raw)
To: gdb-patches
On Sat, Oct 04, 2003 at 02:23:05PM +0200, Corinna Vinschen wrote:
> On Fri, Oct 03, 2003 at 11:22:18AM -0400, Michael Elizabeth Chastain wrote:
> > Proofread, but not tested.
> >
> > Looks fine to me, as long as you say that you've tested it.
>
> Yes, it is tested.
>
> Corinna
>
> > I don't have approval authority.
> >
> > Michael C
> >
> > ===
> >
> > Corinna
> >
> > * gdb.base/ending-run.exp: Add sh specific case.
Ping? Any global maintainer available?
Corinna
--
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFA] testsuite/gdb.base/ending-run.exp: Add sh specific case
@ 2003-10-03 11:05 Corinna Vinschen
2003-10-07 15:53 ` Elena Zannoni
0 siblings, 1 reply; 6+ messages in thread
From: Corinna Vinschen @ 2003-10-03 11:05 UTC (permalink / raw)
To: gdb-patches
Hi,
the comment in the source code says it all. Ok to commit?
Corinna
* gdb.base/ending-run.exp: Add sh specific case.
Index: gdb.base/ending-run.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ending-run.exp,v
retrieving revision 1.21
diff -u -p -r1.21 ending-run.exp
--- gdb.base/ending-run.exp 3 Apr 2003 16:34:48 -0000 1.21
+++ gdb.base/ending-run.exp 3 Oct 2003 11:01:53 -0000
@@ -202,6 +202,11 @@ gdb_expect {
-re ".*in __wrap__?main ().*$gdb_prompt $" {
pass "step out of main (status wrapper)"
}
+ -re "__setup_argv_for_main (.*).*$gdb_prompt $" {
+ # On sh, another wrapper function (start_l) exists, so
+ # another `next' is necessary.
+ gdb_test "next" ".*in start_l ().*" "step out of main (on sh)"
+ }
-re ".*$gdb_prompt $" { fail "step out of main (at end 2)" }
timeout {
fail "step out of main (hang or timeout on step at end 2)"
--
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA] testsuite/gdb.base/ending-run.exp: Add sh specific case
2003-10-03 11:05 Corinna Vinschen
@ 2003-10-07 15:53 ` Elena Zannoni
2003-10-07 16:02 ` Corinna Vinschen
0 siblings, 1 reply; 6+ messages in thread
From: Elena Zannoni @ 2003-10-07 15:53 UTC (permalink / raw)
To: vinschen, gdb-patches
Corinna Vinschen writes:
> Hi,
>
> the comment in the source code says it all. Ok to commit?
>
Sure. All passes with this?
> Corinna
>
> * gdb.base/ending-run.exp: Add sh specific case.
>
> Index: gdb.base/ending-run.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ending-run.exp,v
> retrieving revision 1.21
> diff -u -p -r1.21 ending-run.exp
> --- gdb.base/ending-run.exp 3 Apr 2003 16:34:48 -0000 1.21
> +++ gdb.base/ending-run.exp 3 Oct 2003 11:01:53 -0000
> @@ -202,6 +202,11 @@ gdb_expect {
> -re ".*in __wrap__?main ().*$gdb_prompt $" {
> pass "step out of main (status wrapper)"
> }
> + -re "__setup_argv_for_main (.*).*$gdb_prompt $" {
> + # On sh, another wrapper function (start_l) exists, so
> + # another `next' is necessary.
> + gdb_test "next" ".*in start_l ().*" "step out of main (on sh)"
> + }
> -re ".*$gdb_prompt $" { fail "step out of main (at end 2)" }
> timeout {
> fail "step out of main (hang or timeout on step at end 2)"
>
>
> --
> Corinna Vinschen
> Cygwin Developer
> Red Hat, Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA] testsuite/gdb.base/ending-run.exp: Add sh specific case
2003-10-07 15:53 ` Elena Zannoni
@ 2003-10-07 16:02 ` Corinna Vinschen
0 siblings, 0 replies; 6+ messages in thread
From: Corinna Vinschen @ 2003-10-07 16:02 UTC (permalink / raw)
To: gdb-patches
On Tue, Oct 07, 2003 at 12:04:03PM -0400, Elena Zannoni wrote:
> Corinna Vinschen writes:
> > Hi,
> >
> > the comment in the source code says it all. Ok to commit?
> >
>
> Sure. All passes with this?
Yep!
Thanks, applied,
Corinna
--
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-10-07 16:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-03 15:22 [RFA] testsuite/gdb.base/ending-run.exp: Add sh specific case Michael Elizabeth Chastain
2003-10-04 12:23 ` Corinna Vinschen
2003-10-07 14:55 ` Corinna Vinschen
-- strict thread matches above, loose matches on Subject: below --
2003-10-03 11:05 Corinna Vinschen
2003-10-07 15:53 ` Elena Zannoni
2003-10-07 16:02 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox