From: Daniel Jacobowitz <drow@mvista.com>
To: Richard.Earnshaw@arm.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: GDB PATCH Fix lib/java.exp import of target_alias
Date: Thu, 25 Sep 2003 16:15:00 -0000 [thread overview]
Message-ID: <20030925161513.GB12478@nevyn.them.org> (raw)
In-Reply-To: <200309251610.h8PGA4f27662@pc960.cambridge.arm.com>
On Thu, Sep 25, 2003 at 05:10:04PM +0100, Richard Earnshaw wrote:
>
> lib/java.exp in the testsuite uses the target_alias variable without first
> importing it. That gives a tcl error. This patch fixes that (though it
> doesn't get the tests running for me, it seems that the compiles don't
> work if libjava isn't installed first).
Yeah, this is fine as an obvious fix.
> OK?
>
> R.
>
> <date> Richard Earnshaw <rearnsha@arm.com>
>
> * lib/java.exp (java_init): Import target_alias before using it.
>
>
Content-Description: gdb-java.patch
> Index: java.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/lib/java.exp,v
> retrieving revision 1.1
> diff -p -r1.1 java.exp
> *** java.exp 24 Jul 2000 04:34:52 -0000 1.1
> --- java.exp 25 Sep 2003 16:08:37 -0000
> *************** proc java_init { args } {
> *** 33,38 ****
> --- 33,39 ----
> set GCJ_UNDER_TEST $env(GCJ)
> } else {
> global tool_root_dir
> + global target_alias
>
> if ![is_remote host] {
> set file [lookfor_file $tool_root_dir gcj];
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2003-09-25 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-25 16:10 Richard Earnshaw
2003-09-25 16:15 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030925161513.GB12478@nevyn.them.org \
--to=drow@mvista.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox