From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15252 invoked by alias); 25 Sep 2003 16:15:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15236 invoked from network); 25 Sep 2003 16:15:25 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 25 Sep 2003 16:15:25 -0000 Received: from drow by nevyn.them.org with local (Exim 4.22 #1 (Debian)) id 1A2Ylt-00065d-Kh; Thu, 25 Sep 2003 12:15:13 -0400 Date: Thu, 25 Sep 2003 16:15:00 -0000 From: Daniel Jacobowitz To: Richard.Earnshaw@arm.com Cc: gdb-patches@sources.redhat.com Subject: Re: GDB PATCH Fix lib/java.exp import of target_alias Message-ID: <20030925161513.GB12478@nevyn.them.org> Mail-Followup-To: Richard.Earnshaw@arm.com, gdb-patches@sources.redhat.com References: <200309251610.h8PGA4f27662@pc960.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200309251610.h8PGA4f27662@pc960.cambridge.arm.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-09/txt/msg00565.txt.bz2 On Thu, Sep 25, 2003 at 05:10:04PM +0100, Richard Earnshaw wrote: > > lib/java.exp in the testsuite uses the target_alias variable without first > importing it. That gives a tcl error. This patch fixes that (though it > doesn't get the tests running for me, it seems that the compiles don't > work if libjava isn't installed first). Yeah, this is fine as an obvious fix. > OK? > > R. > > Richard Earnshaw > > * lib/java.exp (java_init): Import target_alias before using it. > > Content-Description: gdb-java.patch > Index: java.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/lib/java.exp,v > retrieving revision 1.1 > diff -p -r1.1 java.exp > *** java.exp 24 Jul 2000 04:34:52 -0000 1.1 > --- java.exp 25 Sep 2003 16:08:37 -0000 > *************** proc java_init { args } { > *** 33,38 **** > --- 33,39 ---- > set GCJ_UNDER_TEST $env(GCJ) > } else { > global tool_root_dir > + global target_alias > > if ![is_remote host] { > set file [lookfor_file $tool_root_dir gcj]; -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer