Re: [rfa] delete xfail from gdb.base/corefile.exp

Re: [rfa] delete xfail from gdb.base/corefile.exp

[Michael Elizabeth Chastain]

Cool with me, although I can't approve it.

Michael C

===

  2003-09-24  David Carlton  <carlton@kealia.com>

	  * gdb.base/corefile.exp: Delete obsolete setup_xfail.

[rfa] delete xfail from gdb.base/corefile.exp

[David Carlton]

Ever since Jim got corefile.exp working on Linux, I've been annoyed by
this:

XPASS: gdb.base/corefile.exp: up in corefile.exp (reinit) (PRMS CLLbs17002)

The test passes reliably, and the message refers to some ancient
bug-tracking system; the easiest solution to me is to just yank the
setup_xfail.  It's possible that the test in question fails on other
systems; the setup_xfail doesn't give me any reason to believe that
that is the case.

Tested on i686-pc-linux-gnu, GCC 3.2, both DWARF-2 and stabs.  OK to
commit?

David Carlton
carlton@kealia.com

2003-09-24  David Carlton  <carlton@kealia.com>

	* gdb.base/corefile.exp: Delete obsolete setup_xfail.

Index: corefile.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/corefile.exp,v
retrieving revision 1.7
diff -u -p -r1.7 corefile.exp
--- corefile.exp	29 May 2003 23:00:02 -0000	1.7
+++ corefile.exp	25 Sep 2003 00:43:27 -0000
@@ -244,7 +244,6 @@ gdb_expect {
 # test reinit_frame_cache
 
 gdb_load ${binfile}
-setup_xfail "*-*-*" CLLbs17002
 gdb_test "up" "#\[0-9\]* *\[0-9xa-fH'\]* in .* \\(\\).*" "up in corefile.exp (reinit)"
 
 gdb_test "core" "No core file now."

Re: [rfa] delete xfail from gdb.base/corefile.exp

[Daniel Jacobowitz]

On Wed, Sep 24, 2003 at 05:47:04PM -0700, David Carlton wrote:
> Ever since Jim got corefile.exp working on Linux, I've been annoyed by
> this:
> 
> XPASS: gdb.base/corefile.exp: up in corefile.exp (reinit) (PRMS CLLbs17002)
> 
> The test passes reliably, and the message refers to some ancient
> bug-tracking system; the easiest solution to me is to just yank the
> setup_xfail.  It's possible that the test in question fails on other
> systems; the setup_xfail doesn't give me any reason to believe that
> that is the case.
> 
> Tested on i686-pc-linux-gnu, GCC 3.2, both DWARF-2 and stabs.  OK to
> commit?

Please do, in fact.

> 2003-09-24  David Carlton  <carlton@kealia.com>
> 
> 	* gdb.base/corefile.exp: Delete obsolete setup_xfail.
> 
> Index: corefile.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/corefile.exp,v
> retrieving revision 1.7
> diff -u -p -r1.7 corefile.exp
> --- corefile.exp	29 May 2003 23:00:02 -0000	1.7
> +++ corefile.exp	25 Sep 2003 00:43:27 -0000
> @@ -244,7 +244,6 @@ gdb_expect {
>  # test reinit_frame_cache
>  
>  gdb_load ${binfile}
> -setup_xfail "*-*-*" CLLbs17002
>  gdb_test "up" "#\[0-9\]* *\[0-9xa-fH'\]* in .* \\(\\).*" "up in corefile.exp (reinit)"
>  
>  gdb_test "core" "No core file now."
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [rfa] delete xfail from gdb.base/corefile.exp

[Andrew Cagney]

> On Wed, Sep 24, 2003 at 05:47:04PM -0700, David Carlton wrote:
> 
>> Ever since Jim got corefile.exp working on Linux, I've been annoyed by
>> this:
>> 
>> XPASS: gdb.base/corefile.exp: up in corefile.exp (reinit) (PRMS CLLbs17002)
>> 
>> The test passes reliably, and the message refers to some ancient
>> bug-tracking system;

FYI, it's from hp (their internal system I think).

Andrew

Re: [rfa] delete xfail from gdb.base/corefile.exp

[David Carlton]

On Wed, 24 Sep 2003 20:49:43 -0400, Daniel Jacobowitz <drow@mvista.com> said:

>> Tested on i686-pc-linux-gnu, GCC 3.2, both DWARF-2 and stabs.  OK to
>> commit?

> Please do, in fact.

Thanks, committed.

David Carlton
carlton@kealia.com