Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf@redhat.com>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Properly define SSE registers for cygwin targets
Date: Sat, 13 Sep 2003 15:52:00 -0000	[thread overview]
Message-ID: <20030913155157.GA15291@redhat.com> (raw)
In-Reply-To: <200309131102.h8DB2xvx077846@elgar.kettenis.dyndns.org>

On Sat, Sep 13, 2003 at 01:02:59PM +0200, Mark Kettenis wrote:
>   Date: Fri, 12 Sep 2003 22:27:59 -0400
>   From: Christopher Faylor <cgf@redhat.com>
>
>   Checked in, trunk and branch.
>
>   cgf
>
>   2003-09-12  Christopher Faylor  <cgf@redhat.com>
>
>	   * win32-nat.c: Reorganize so that defines used by target headers are
>	   actually defined by the system headers.
>	   * config/i386/tm-cygwin.h: Check for CONTEXT_EXTENDED_REGISTERS rather
>	   than HAVE_CONTEXT_EXTENDED_REGISTERS, since the latter actually exists.
>
>Hmm, this looks like a lost opportunity to get rid of a definition in
>tm-cygwin.h.  HAVE_SSE_REGS has been eliminated from all source files
>except win32-nat.c.  So a s/HAVE_SSE_REGS/CONTEXT_EXTENDED_REGISTERS/g
>in that file would have been sufficient.  This also removes the need
>to re-order the includes; out coding standards say that "defs.h"
>should always come first.

Where do you think CONTEXT_EXTENDED_REGISTERS comes from?

Another question:  If HAVE_SSE_REGS was eliminated from all source files
why wasn't it eliminated from win32-nat.c?  Did I miss a memo?

cgf


  reply	other threads:[~2003-09-13 15:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-13  2:28 Christopher Faylor
2003-09-13 11:03 ` Mark Kettenis
2003-09-13 15:52   ` Christopher Faylor [this message]
2003-09-13 16:04     ` Christopher Faylor
2003-09-14 15:46     ` Mark Kettenis
2003-09-14 17:35       ` Christopher Faylor
2003-09-13 17:02 ` [PATCH] Make SSE registers unconditionally available on cygwin Christopher Faylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030913155157.GA15291@redhat.com \
    --to=cgf@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox