From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30878 invoked by alias); 13 Sep 2003 15:52:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30740 invoked from network); 13 Sep 2003 15:52:00 -0000 Received: from unknown (HELO redhat.com) (24.131.133.249) by sources.redhat.com with SMTP; 13 Sep 2003 15:52:00 -0000 Received: by redhat.com (Postfix, from userid 201) id AA5A332A822; Sat, 13 Sep 2003 11:51:57 -0400 (EDT) Date: Sat, 13 Sep 2003 15:52:00 -0000 From: Christopher Faylor To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Properly define SSE registers for cygwin targets Message-ID: <20030913155157.GA15291@redhat.com> Mail-Followup-To: Mark Kettenis , gdb-patches@sources.redhat.com References: <20030913022759.GA2225@redhat.com> <200309131102.h8DB2xvx077846@elgar.kettenis.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200309131102.h8DB2xvx077846@elgar.kettenis.dyndns.org> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-09/txt/msg00289.txt.bz2 On Sat, Sep 13, 2003 at 01:02:59PM +0200, Mark Kettenis wrote: > Date: Fri, 12 Sep 2003 22:27:59 -0400 > From: Christopher Faylor > > Checked in, trunk and branch. > > cgf > > 2003-09-12 Christopher Faylor > > * win32-nat.c: Reorganize so that defines used by target headers are > actually defined by the system headers. > * config/i386/tm-cygwin.h: Check for CONTEXT_EXTENDED_REGISTERS rather > than HAVE_CONTEXT_EXTENDED_REGISTERS, since the latter actually exists. > >Hmm, this looks like a lost opportunity to get rid of a definition in >tm-cygwin.h. HAVE_SSE_REGS has been eliminated from all source files >except win32-nat.c. So a s/HAVE_SSE_REGS/CONTEXT_EXTENDED_REGISTERS/g >in that file would have been sufficient. This also removes the need >to re-order the includes; out coding standards say that "defs.h" >should always come first. Where do you think CONTEXT_EXTENDED_REGISTERS comes from? Another question: If HAVE_SSE_REGS was eliminated from all source files why wasn't it eliminated from win32-nat.c? Did I miss a memo? cgf