From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Cc: carlton@kealia.com, ezannoni@redhat.com
Subject: Re: [rfa] generate symbols associated to namespaces
Date: Sun, 31 Aug 2003 19:29:00 -0000 [thread overview]
Message-ID: <20030831192950.GA20616@nevyn.them.org> (raw)
In-Reply-To: <20030805175429.GA29704@nevyn.them.org>
On Tue, Aug 05, 2003 at 01:54:29PM -0400, Daniel Jacobowitz wrote:
> On Fri, Jun 27, 2003 at 02:58:50PM -0700, David Carlton wrote:
> > On Fri, 27 Jun 2003 09:04:13 -0700, David Carlton <carlton@kealia.com> said:
> >
> > > I've looked at your code comments, and they all seem reasonable. I
> > > hope I'll have a revised version of the patch today; job transition
> > > issues will take up some of my time (I start full-time work at
> > > Kealia today, so I have to figure out what they want me to do other
> > > than hack GDB), but it's near the top of my priority list.
> >
> > Okay, here's the new version. Following Daniel's suggestion, it puts
> > symbols associated to DW_TAG_namespace in the symtab where they are
> > found, instead of in a special block, and creates one possible
> > namespace block for each objfile. This fixes the problem Daniel found
> > with the last version of my patch (which, incidentally, turns out also
> > to show up under DWARF 2 with pr-1210.exp; the more tests the
> > merrier).
> >
> > Tested with GCC 3.2, i686-pc-linux-gnu with both DWARF 2 and stabs+,
> > and with a version of GCC 3.2.3 that generates DW_TAG_namespace DIEs.
> > No new regressions (though the new tests in gdb.c++/namespace.exp fail
> > under stabs+, as expected).
> >
> > How does this one look to y'all?
>
> Sorry 'bout the delay. This looks good to me; Elena?
This patch needs a trivial update for the gdb.c++ -> gdb.cp rename, and
IIRC one other merge update for the testsuite; and the comments we
discussed downthread. Mind reposting it?
Elena, could you look at this? I have some other C++ work which is
blocked waiting for this patch.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-08-31 19:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-16 20:22 David Carlton
2003-06-22 17:42 ` Daniel Jacobowitz
2003-06-24 19:00 ` David Carlton
2003-06-24 19:02 ` Daniel Jacobowitz
2003-06-27 16:04 ` David Carlton
2003-06-27 21:58 ` David Carlton
2003-06-27 22:32 ` David Carlton
2003-08-05 16:30 ` David Carlton
2003-08-05 17:54 ` Daniel Jacobowitz
2003-08-05 18:06 ` David Carlton
2003-08-05 18:08 ` Daniel Jacobowitz
2003-08-05 18:18 ` David Carlton
2003-08-31 19:29 ` Daniel Jacobowitz [this message]
2003-09-02 16:38 ` David Carlton
2003-09-09 19:42 ` Elena Zannoni
2003-09-09 20:28 ` David Carlton
2003-09-09 22:17 ` Elena Zannoni
2003-09-09 23:25 ` David Carlton
2003-09-11 19:52 ` David Carlton
2003-09-17 20:41 ` David Carlton
2003-09-11 23:28 ` [rfa] use allocate_block more David Carlton
2003-09-11 23:33 ` Elena Zannoni
2003-09-11 23:44 ` David Carlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030831192950.GA20616@nevyn.them.org \
--to=drow@mvista.com \
--cc=carlton@kealia.com \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox