From: Daniel Jacobowitz <drow@mvista.com>
To: Jafa <jafa@silicondust.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] missing case in epilogue stub detection
Date: Tue, 26 Aug 2003 22:45:00 -0000 [thread overview]
Message-ID: <20030826224530.GA28636@nevyn.them.org> (raw)
In-Reply-To: <00f901c36c22$8fe12250$0502a8c0@scenix.com>
On Tue, Aug 26, 2003 at 03:36:59PM -0700, Jafa wrote:
> The following patch fixes a bug where an epilogue stub isn't detected and is
> erroneously treated as a subroutine.
>
> Fixes step and next errors when at the end of a function for the ip2k. Mips
> may have suffered from the same problem but the occurrence of the code would
> have been rare.
>
> 2003-08-26 Nick Kelsey <nickk@ubicom.com>
>
> * infrun.c (handle_inferior_event): Bug fix in subroutine detection
> code regarding dealing with an epilogue stub. The previous code correctly
> detected the stub in all cases except where the pc is equal to the stub
> entry point.
First of all, please use context or (my preference) unified diff.
Second of all, please obey the coding standards; you removed a comment
and made a line too long.
And the actual problem, please explain what the bug is and why this
change is correct. From the patch I'll make a wild guess: stop_pc ==
ecs->stop_func_start but in_prologue returns false. That looks like a
bug in your target's prologue code.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-08-26 22:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-31 22:01 RFA: patch to display ia64 function pointers J. Johnston
2003-08-25 21:12 ` Kevin Buettner
2003-08-26 17:34 ` J. Johnston
2003-08-26 22:37 ` [patch] missing case in epilogue stub detection Jafa
2003-08-26 22:45 ` Daniel Jacobowitz [this message]
2003-08-26 23:01 ` Jafa
2003-09-07 15:16 ` Daniel Jacobowitz
2003-09-09 3:00 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030826224530.GA28636@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jafa@silicondust.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox