From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8968 invoked by alias); 26 Aug 2003 22:45:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8956 invoked from network); 26 Aug 2003 22:45:31 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 26 Aug 2003 22:45:31 -0000 Received: from drow by nevyn.them.org with local (Exim 4.20 #1 (Debian)) id 19rmZ9-0007Te-07; Tue, 26 Aug 2003 18:45:31 -0400 Date: Tue, 26 Aug 2003 22:45:00 -0000 From: Daniel Jacobowitz To: Jafa Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] missing case in epilogue stub detection Message-ID: <20030826224530.GA28636@nevyn.them.org> Mail-Followup-To: Jafa , gdb-patches@sources.redhat.com References: <3F2991AA.2050400@redhat.com> <1030825211237.ZM7510@localhost.localdomain> <3F4B9A2A.6020901@redhat.com> <00f901c36c22$8fe12250$0502a8c0@scenix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00f901c36c22$8fe12250$0502a8c0@scenix.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-08/txt/msg00462.txt.bz2 On Tue, Aug 26, 2003 at 03:36:59PM -0700, Jafa wrote: > The following patch fixes a bug where an epilogue stub isn't detected and is > erroneously treated as a subroutine. > > Fixes step and next errors when at the end of a function for the ip2k. Mips > may have suffered from the same problem but the occurrence of the code would > have been rare. > > 2003-08-26 Nick Kelsey > > * infrun.c (handle_inferior_event): Bug fix in subroutine detection > code regarding dealing with an epilogue stub. The previous code correctly > detected the stub in all cases except where the pc is equal to the stub > entry point. First of all, please use context or (my preference) unified diff. Second of all, please obey the coding standards; you removed a comment and made a line too long. And the actual problem, please explain what the bug is and why this change is correct. From the patch I'll make a wild guess: stop_pc == ecs->stop_func_start but in_prologue returns false. That looks like a bug in your target's prologue code. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer