From: Michael Elizabeth Chastain <mec@shout.net>
To: jimb@redhat.com
Cc: ezannoni@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [rfa] space reduction in gdbtypes.h
Date: Wed, 20 Aug 2003 20:23:00 -0000 [thread overview]
Message-ID: <200308202023.h7KKNP6G011437@duracef.shout.net> (raw)
Hi Jim,
jimb> - I think it's important that this struct start with something that
jimb> indicates which sort of type it represents. It's weird to have the
jimb> discriminant buried in the middle. So leave 'code' the first member
jimb> of the structure, and move the {upper,lower}_bound_type fields up.
jimb> - Add a short comment indicating that the {upper,lower}_bound_type
jimb> fields pack better at that location.
Okay, I will do that, and re-test, and then commit.
I thought about trying the __packed__ attribute but I am allergic to
__packed__ because I've seen that word in too many bug reports. My gut
feeling is that hand layout is safer.
This is the last of the "easy re-arrangement" patches. Next I will
write an essay about the minsyms 'info' pointer, which really bites,
and submit some cleanup patches for that.
Michael C
next reply other threads:[~2003-08-20 20:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-20 20:23 Michael Elizabeth Chastain [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-08-21 4:33 Michael Elizabeth Chastain
2003-08-21 14:10 ` Andrew Cagney
2003-08-20 23:02 Michael Elizabeth Chastain
2003-08-20 17:46 Michael Elizabeth Chastain
2003-08-20 19:55 ` Jim Blandy
2003-08-21 4:04 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308202023.h7KKNP6G011437@duracef.shout.net \
--to=mec@shout.net \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox