From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13434 invoked by alias); 20 Aug 2003 20:23:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13423 invoked from network); 20 Aug 2003 20:23:40 -0000 Received: from unknown (HELO concert.shout.net) (204.253.184.25) by sources.redhat.com with SMTP; 20 Aug 2003 20:23:40 -0000 Received: from duracef.shout.net (duracef.shout.net [204.253.184.12]) by concert.shout.net (8.12.9/8.12.9) with ESMTP id h7KKNQca030133; Wed, 20 Aug 2003 15:23:26 -0500 Received: from duracef.shout.net (localhost [127.0.0.1]) by duracef.shout.net (8.12.9/8.12.9) with ESMTP id h7KKNQHK011438; Wed, 20 Aug 2003 15:23:26 -0500 Received: (from mec@localhost) by duracef.shout.net (8.12.9/8.12.9/Submit) id h7KKNP6G011437; Wed, 20 Aug 2003 16:23:25 -0400 Date: Wed, 20 Aug 2003 20:23:00 -0000 From: Michael Elizabeth Chastain Message-Id: <200308202023.h7KKNP6G011437@duracef.shout.net> To: jimb@redhat.com Subject: Re: [rfa] space reduction in gdbtypes.h Cc: ezannoni@redhat.com, gdb-patches@sources.redhat.com X-SW-Source: 2003-08/txt/msg00346.txt.bz2 Hi Jim, jimb> - I think it's important that this struct start with something that jimb> indicates which sort of type it represents. It's weird to have the jimb> discriminant buried in the middle. So leave 'code' the first member jimb> of the structure, and move the {upper,lower}_bound_type fields up. jimb> - Add a short comment indicating that the {upper,lower}_bound_type jimb> fields pack better at that location. Okay, I will do that, and re-test, and then commit. I thought about trying the __packed__ attribute but I am allergic to __packed__ because I've seen that word in too many bug reports. My gut feeling is that hand layout is safer. This is the last of the "easy re-arrangement" patches. Next I will write an essay about the minsyms 'info' pointer, which really bites, and submit some cleanup patches for that. Michael C