Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFA] Sync window sizes between Readline and GDB
Date: Sun, 17 Aug 2003 20:35:00 -0000	[thread overview]
Message-ID: <20030817203504.GA11124@nevyn.them.org> (raw)
In-Reply-To: <200308171841.h7HIfDdl034523@elgar.kettenis.dyndns.org>

On Sun, Aug 17, 2003 at 08:41:13PM +0200, Mark Kettenis wrote:
> Folks,
> 
> The attached makes sure GDB's and Readline's idea of the screen size
> are the same.  It gets rid of some rather platform-specific code and
> uses similar code in Readline instead.  This fixes the problems I was
> seeing in completion.exp.
> 
> I don't think we should check this in on the branch, since there is a
> certain risk involved that things break for certain hosts.  However, I
> think making use of the code in Readline is a good thing since that
> code is defenitely better tested than our code.
> 
> OK for mainline?

This certainly looks like a good idea to me.  I tried it on a GNU/Linux
system that was showing similar problems, and it fixed those as well.

It introduces new warnings in utils.c though.  There's one call to
set_width above its declaration and you removed the prototype.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-08-17 20:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-17 18:41 Mark Kettenis
2003-08-17 20:35 ` Daniel Jacobowitz [this message]
2003-08-18  9:53 ` Eli Zaretskii
2003-08-18 17:24   ` Mark Kettenis
2003-08-22 20:23   ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030817203504.GA11124@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox