From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31030 invoked by alias); 17 Aug 2003 20:35:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31011 invoked from network); 17 Aug 2003 20:35:08 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 17 Aug 2003 20:35:08 -0000 Received: from drow by nevyn.them.org with local (Exim 4.20 #1 (Debian)) id 19oUEy-0002w3-KE for ; Sun, 17 Aug 2003 16:35:04 -0400 Date: Sun, 17 Aug 2003 20:35:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFA] Sync window sizes between Readline and GDB Message-ID: <20030817203504.GA11124@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <200308171841.h7HIfDdl034523@elgar.kettenis.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200308171841.h7HIfDdl034523@elgar.kettenis.dyndns.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-08/txt/msg00275.txt.bz2 On Sun, Aug 17, 2003 at 08:41:13PM +0200, Mark Kettenis wrote: > Folks, > > The attached makes sure GDB's and Readline's idea of the screen size > are the same. It gets rid of some rather platform-specific code and > uses similar code in Readline instead. This fixes the problems I was > seeing in completion.exp. > > I don't think we should check this in on the branch, since there is a > certain risk involved that things break for certain hosts. However, I > think making use of the code in Readline is a good thing since that > code is defenitely better tested than our code. > > OK for mainline? This certainly looks like a good idea to me. I tried it on a GNU/Linux system that was showing similar problems, and it fixed those as well. It introduces new warnings in utils.c though. There's one call to set_width above its declaration and you removed the prototype. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer