Re: PATCH: Fix DW_OP_deref for DW_TAG_formal_parameter

["H. J. Lu" <hjl@lucon.org>]

On Thu, Jul 31, 2003 at 12:22:07PM -0400, Daniel Jacobowitz wrote:
> On Thu, Jul 31, 2003 at 09:12:59AM -0700, H. J. Lu wrote:
> > On Thu, Jul 31, 2003 at 11:48:21AM -0400, Daniel Jacobowitz wrote:
> > > On Thu, Jul 31, 2003 at 08:44:05AM -0700, H. J. Lu wrote:
> > > > On Wed, Jul 30, 2003 at 08:27:53PM -0400, Daniel Jacobowitz wrote:
> > > > > On Wed, Jul 30, 2003 at 05:23:06PM -0700, H. J. Lu wrote:
> > > > > > On Wed, Jul 30, 2003 at 05:56:12PM -0400, Daniel Jacobowitz wrote:
> > > > > > > On Wed, Jul 30, 2003 at 02:54:21PM -0700, H. J. Lu wrote:
> > > > > > > > Does DW_OP_deref work correctly with gdb?
> > > > > > > 
> > > > > > > That depends on the context.  Things that use decode_locdesc, probably
> > > > > > > not.  As we find time, things are being converted to the full
> > > > > > > expression evaluator.  Location descriptions and frame bases should
> > > > > > > work.
> > > > > > 
> > > > > > I don't think it does. Intel Fortran compiler generartes DW_OP_deref.
> > > > > > I got
> > > > > 
> > > > > Location descriptions for parameters may not work fully.  Feel free to
> > > > > fix it, or to investigate the reasons why more thoroughly - search for
> > > > > LOC_COMPUTED_ARG, but I don't even think we generate those yet.
> > > > > 
> > > > 
> > 
> > > Please look more closely at what I suggested, and at how DW_OP_deref
> > > works for DW_TAG_variable (as opposed to DW_TAG_formal_parameter).  All
> > > of the above should be turned into LOC_COMPUTED_ARG.
> > > 
> > 
> > Thanks. This patch works for me.
> 
> Could you test this alternative?  The goal is to eliminate calls to
> decode_locdesc.
> 

Yes, it works.

Thanks.


H.J.