Re: [commit, 6.0] Fix fileio test cleanup

Re: [commit, 6.0] Fix fileio test cleanup

[Michael Elizabeth Chastain]

drow> Did notice, didn't figure out what to do about it.  Thanks - the
drow> unwritable directory was a real nuisance.

Ah, yeah, I noticed that too, I'm glad Andrew handled it before
I paid much attention to it.  Cool beans.

It wasn't bugging me because the Perl function to delete trees
quietly does its own "chmod".

Michael C

[commit, 6.0] Fix fileio test cleanup

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

(suprised no one noticed)
I didn't quite get the switch from system->remote_exec right in the file 
I/O tests.  This fixes the problem - remote_exec wasn't doing shell 
expansion.

committed to 6.0 and mainline,
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1185 bytes --]

2003-07-27  Andrew Cagney  <cagney@redhat.com>

	* gdb.base/fileio.exp: Use SH when running commands using
	remote_exec.

Index: testsuite/gdb.base/fileio.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/fileio.exp,v
retrieving revision 1.3
diff -u -r1.3 fileio.exp
--- testsuite/gdb.base/fileio.exp	14 Jun 2003 16:51:42 -0000	1.3
+++ testsuite/gdb.base/fileio.exp	27 Jul 2003 20:44:49 -0000
@@ -52,8 +52,8 @@
     return -1;
 }
 
-remote_exec build "test -r dir2.fileio.test && chmod -f +w dir2.fileio.test"
-remote_exec build "rm -rf *.fileio.test"
+remote_exec build {sh -xc test\ -r\ dir2.fileio.test\ &&\ chmod\ -f\ +w\ dir2.fileio.test}
+remote_exec build {sh -xc rm\ -rf\ *.fileio.test}
 
 set oldtimeout $timeout
 set timeout [expr "$timeout + 60"]
@@ -269,9 +269,8 @@
 send_gdb "quit\n"
 send_gdb "y\n"
 
-remote_exec build "test -r dir2.fileio.test && chmod -f +w dir2.fileio.test"
-remote_exec build "rm -rf *.fileio.test"
+remote_exec build {sh -xc test\ -r\ dir2.fileio.test\ &&\ chmod\ -f\ +w\ dir2.fileio.test}
+remote_exec build {sh -xc rm\ -rf\ *.fileio.test}
 
 set timeout $oldtimeout
 return 0
-

Re: [commit, 6.0] Fix fileio test cleanup

[Daniel Jacobowitz]

On Sun, Jul 27, 2003 at 05:18:03PM -0400, Andrew Cagney wrote:
> (suprised no one noticed)
> I didn't quite get the switch from system->remote_exec right in the file 
> I/O tests.  This fixes the problem - remote_exec wasn't doing shell 
> expansion.

Did notice, didn't figure out what to do about it.  Thanks - the
unwritable directory was a real nuisance.

I'm not sure that's going to work in all cases, though.  How much
quoting remote_exec does depends on what your exec target is - this may
mangle rsh testing.  I'll have to run through that again sometime, so
don't worry about it.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer