From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Cc: Kei Sakamoto <sakamoto.kei@renesas.com>
Subject: Re: [patch/testcase] fix gdb.base/relocate.c
Date: Thu, 24 Jul 2003 18:47:00 -0000 [thread overview]
Message-ID: <20030724184704.GB1842@nevyn.them.org> (raw)
In-Reply-To: <20030708025830.GA27558@nevyn.them.org>
On Mon, Jul 07, 2003 at 10:58:30PM -0400, Daniel Jacobowitz wrote:
> On Tue, Jul 08, 2003 at 11:56:07AM +0900, Kei Sakamoto wrote:
> > 2003-07-08 Kei Sakamoto <sakamoto.kei@renesas.com>
> >
> > * gdb.base/relocate.c : Add a dummy array to make global_bar
> > and function_bar have different addresses.
>
> Ugh, this is OK, since the test can only reliably specify an offset for
> .text.
I've checked this in, with updated commentary.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
2003-07-24 Daniel Jacobowitz <drow@mvista.com>
From Kei Sakamoto <sakamoto.kei@renesas.com>:
* gdb.base/relocate.c (dummy): New padding array.
Index: gdb.base/relocate.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/relocate.c,v
retrieving revision 1.1
diff -u -p -r1.1 relocate.c
--- gdb.base/relocate.c 5 Apr 2002 02:45:48 -0000 1.1
+++ gdb.base/relocate.c 24 Jul 2003 18:44:36 -0000
@@ -1,6 +1,10 @@
static int static_foo = 1;
static int static_bar = 2;
+/* This padding is just for the benefit of the test harness. It
+ causes the globals to have different addresses than the functions. */
+int dummy[] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0};
+
int global_foo = 3;
int global_bar = 4;
prev parent reply other threads:[~2003-07-24 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-08 2:53 Kei Sakamoto
2003-07-08 2:58 ` Daniel Jacobowitz
2003-07-24 18:47 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030724184704.GB1842@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=sakamoto.kei@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox