From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14221 invoked by alias); 24 Jul 2003 18:47:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14213 invoked from network); 24 Jul 2003 18:47:08 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 24 Jul 2003 18:47:08 -0000 Received: from drow by nevyn.them.org with local (Exim 4.20 #1 (Debian)) id 19fl7I-00025I-K6; Thu, 24 Jul 2003 14:47:04 -0400 Date: Thu, 24 Jul 2003 18:47:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Cc: Kei Sakamoto Subject: Re: [patch/testcase] fix gdb.base/relocate.c Message-ID: <20030724184704.GB1842@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, Kei Sakamoto References: <014401c344fc$7b0972d0$5169910a@KEI> <20030708025830.GA27558@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030708025830.GA27558@nevyn.them.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-07/txt/msg00432.txt.bz2 On Mon, Jul 07, 2003 at 10:58:30PM -0400, Daniel Jacobowitz wrote: > On Tue, Jul 08, 2003 at 11:56:07AM +0900, Kei Sakamoto wrote: > > 2003-07-08 Kei Sakamoto > > > > * gdb.base/relocate.c : Add a dummy array to make global_bar > > and function_bar have different addresses. > > Ugh, this is OK, since the test can only reliably specify an offset for > .text. I've checked this in, with updated commentary. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2003-07-24 Daniel Jacobowitz From Kei Sakamoto : * gdb.base/relocate.c (dummy): New padding array. Index: gdb.base/relocate.c =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/relocate.c,v retrieving revision 1.1 diff -u -p -r1.1 relocate.c --- gdb.base/relocate.c 5 Apr 2002 02:45:48 -0000 1.1 +++ gdb.base/relocate.c 24 Jul 2003 18:44:36 -0000 @@ -1,6 +1,10 @@ static int static_foo = 1; static int static_bar = 2; +/* This padding is just for the benefit of the test harness. It + causes the globals to have different addresses than the functions. */ +int dummy[] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; + int global_foo = 3; int global_bar = 4;