From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [patch, rfc] frame attribute - FRAME_IS_CALLER
Date: Wed, 09 Jul 2003 21:29:00 -0000 [thread overview]
Message-ID: <20030709212907.GA27628@nevyn.them.org> (raw)
In-Reply-To: <3F0C7533.4090003@redhat.com>
On Wed, Jul 09, 2003 at 04:04:03PM -0400, Andrew Cagney wrote:
> Hello,
>
> Ref: Add frame_is_callee_p(), use in dwarf2-frame.c?,
> http://sources.redhat.com/ml/gdb-patches/2003-07/msg00046.html
>
> This patch adds a new `frame attribute' methods and defines one
> attribute `FRAME_IS_CALLER' (described in comment) (again better name?).
>
> It then uses it in a couple random places so that i know it is working.
>
> thoughts,
>
> The attached would be committed to the mainline, and just the new
> methods to the branch.
>
> Andrew
Shouldn't FRAME_IS_CALLER only be true if THIS->type == NORMAL_FRAME &&
NEXT->type == NORMAL_FRAME? If NEXT->type == NORMAL_FRAME but
THIS->type == DUMMY_FRAME, then NEXT's return PC shouldn't be
decremented, et cetera.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-07-09 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-09 20:04 Andrew Cagney
2003-07-09 21:29 ` Daniel Jacobowitz [this message]
2003-07-10 19:03 ` Andrew Cagney
2003-07-15 17:39 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030709212907.GA27628@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox