From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22704 invoked by alias); 9 Jul 2003 21:29:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22693 invoked from network); 9 Jul 2003 21:29:07 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 9 Jul 2003 21:29:07 -0000 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19aMUt-0007DL-00 for ; Wed, 09 Jul 2003 17:29:07 -0400 Date: Wed, 09 Jul 2003 21:29:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [patch, rfc] frame attribute - FRAME_IS_CALLER Message-ID: <20030709212907.GA27628@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <3F0C7533.4090003@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F0C7533.4090003@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-07/txt/msg00196.txt.bz2 On Wed, Jul 09, 2003 at 04:04:03PM -0400, Andrew Cagney wrote: > Hello, > > Ref: Add frame_is_callee_p(), use in dwarf2-frame.c?, > http://sources.redhat.com/ml/gdb-patches/2003-07/msg00046.html > > This patch adds a new `frame attribute' methods and defines one > attribute `FRAME_IS_CALLER' (described in comment) (again better name?). > > It then uses it in a couple random places so that i know it is working. > > thoughts, > > The attached would be committed to the mainline, and just the new > methods to the branch. > > Andrew Shouldn't FRAME_IS_CALLER only be true if THIS->type == NORMAL_FRAME && NEXT->type == NORMAL_FRAME? If NEXT->type == NORMAL_FRAME but THIS->type == DUMMY_FRAME, then NEXT's return PC shouldn't be decremented, et cetera. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer