From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [patch, rfc, 6?] Enable identical frame sanity check
Date: Wed, 02 Jul 2003 18:36:00 -0000 [thread overview]
Message-ID: <20030702183600.GB8828@nevyn.them.org> (raw)
In-Reply-To: <3F03241B.1020908@redhat.com>
On Wed, Jul 02, 2003 at 02:27:39PM -0400, Andrew Cagney wrote:
> Hello,
>
> This patch enables the `is the prev frame identical to this frame' check
> in get_prev_frame(). I forgot to enable it when I switched the frame ID
> code from using the frame's PC to using the frame's function. Noticed
> this when reviewing Daniel's Arm frame update.
>
> It should probably go straight into the mainline (tested on i386 and d10v).
d10v, AVR, and soon ARM all include this check as a silent stop
condition rather than an error... perhaps that has some significance.
I know it's hit at least on ARM. I'd have to dumb down the prologue
analyzer if I wanted it not to be, or else figure out where an
inside_entry_func check has gone completely missing in the new frame
code. Just putting it unwind_this_id didn't work (don't remember why
not).
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-07-02 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-02 18:27 Andrew Cagney
2003-07-02 18:36 ` Daniel Jacobowitz [this message]
2003-07-03 15:27 ` Andrew Cagney
2003-07-07 14:16 ` Daniel Jacobowitz
2003-07-07 19:05 ` Andrew Cagney
2003-07-07 15:32 ` Andrew Cagney
2003-07-07 19:47 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030702183600.GB8828@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox