From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5487 invoked by alias); 2 Jul 2003 18:36:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5478 invoked from network); 2 Jul 2003 18:36:02 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 2 Jul 2003 18:36:02 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19XmTU-0002Hp-00 for ; Wed, 02 Jul 2003 13:37:00 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19XmSW-0002Ke-00 for ; Wed, 02 Jul 2003 14:36:00 -0400 Date: Wed, 02 Jul 2003 18:36:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [patch, rfc, 6?] Enable identical frame sanity check Message-ID: <20030702183600.GB8828@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <3F03241B.1020908@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F03241B.1020908@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-07/txt/msg00045.txt.bz2 On Wed, Jul 02, 2003 at 02:27:39PM -0400, Andrew Cagney wrote: > Hello, > > This patch enables the `is the prev frame identical to this frame' check > in get_prev_frame(). I forgot to enable it when I switched the frame ID > code from using the frame's PC to using the frame's function. Noticed > this when reviewing Daniel's Arm frame update. > > It should probably go straight into the mainline (tested on i386 and d10v). d10v, AVR, and soon ARM all include this check as a silent stop condition rather than an error... perhaps that has some significance. I know it's hit at least on ARM. I'd have to dumb down the prologue analyzer if I wanted it not to be, or else figure out where an inside_entry_func check has gone completely missing in the new frame code. Just putting it unwind_this_id didn't work (don't remember why not). -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer