Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com, rearnsha@arm.com
Subject: Re: [RFA/ARM] Framificate the ARM port [3/3]
Date: Tue, 01 Jul 2003 22:26:00 -0000	[thread overview]
Message-ID: <20030701222615.GA13782@nevyn.them.org> (raw)
In-Reply-To: <3F01D27B.8070603@redhat.com>

On Tue, Jul 01, 2003 at 02:27:07PM -0400, Andrew Cagney wrote:
> >Index: gdb/varobj.c
> >===================================================================
> >--- gdb.orig/varobj.c	2003-06-30 18:28:07.000000000 -0400
> >+++ gdb/varobj.c	2003-06-30 18:28:57.000000000 -0400
> >@@ -412,7 +412,7 @@ find_frame_addr_in_frame_chain (CORE_ADD
> >       frame = get_prev_frame (frame);
> >       if (frame == NULL)
> > 	return NULL;
> >-      if (get_frame_base (frame) == frame_addr)
> >+      if (get_frame_base_address (frame) == frame_addr)
> > 	return frame;
> >     }
> 
> Just in case you're wondering.
> 
> This would break any architecture that didn't have an FP called "fp". 
> This is because, "$fp" defaults to get_frame_base() ... :-(

Argh!

get_frame_base_address defaults to get_frame_base; I could update
value_of_builtin_frame_fp_reg safely, I think.  But I have no idea
where that would end up, so I'm going to defer to your judgement on
this if you've got a preference...

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-07-01 22:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-30 22:55 Daniel Jacobowitz
2003-07-01 15:32 ` Andrew Cagney
2003-07-07 13:47   ` Daniel Jacobowitz
2003-07-07 14:46     ` Andrew Cagney
2003-07-07 21:12       ` Daniel Jacobowitz
2003-07-01 18:27 ` Andrew Cagney
2003-07-01 22:26   ` Daniel Jacobowitz [this message]
2003-07-01 23:24     ` Andrew Cagney
2003-07-07 13:53       ` Daniel Jacobowitz
2003-07-07 14:23 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030701222615.GA13782@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox