From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8130 invoked by alias); 1 Jul 2003 22:26:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8122 invoked from network); 1 Jul 2003 22:26:25 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 1 Jul 2003 22:26:25 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19XTal-0000Ng-00; Tue, 01 Jul 2003 17:27:16 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19XTZn-0003dX-00; Tue, 01 Jul 2003 18:26:15 -0400 Date: Tue, 01 Jul 2003 22:26:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com, rearnsha@arm.com Subject: Re: [RFA/ARM] Framificate the ARM port [3/3] Message-ID: <20030701222615.GA13782@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb-patches@sources.redhat.com, rearnsha@arm.com References: <20030630225509.GA30844@nevyn.them.org> <3F01D27B.8070603@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F01D27B.8070603@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-07/txt/msg00022.txt.bz2 On Tue, Jul 01, 2003 at 02:27:07PM -0400, Andrew Cagney wrote: > >Index: gdb/varobj.c > >=================================================================== > >--- gdb.orig/varobj.c 2003-06-30 18:28:07.000000000 -0400 > >+++ gdb/varobj.c 2003-06-30 18:28:57.000000000 -0400 > >@@ -412,7 +412,7 @@ find_frame_addr_in_frame_chain (CORE_ADD > > frame = get_prev_frame (frame); > > if (frame == NULL) > > return NULL; > >- if (get_frame_base (frame) == frame_addr) > >+ if (get_frame_base_address (frame) == frame_addr) > > return frame; > > } > > Just in case you're wondering. > > This would break any architecture that didn't have an FP called "fp". > This is because, "$fp" defaults to get_frame_base() ... :-( Argh! get_frame_base_address defaults to get_frame_base; I could update value_of_builtin_frame_fp_reg safely, I think. But I have no idea where that would end up, so I'm going to defer to your judgement on this if you've got a preference... -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer