From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Fix new failures in break.exp
Date: Thu, 19 Jun 2003 20:38:00 -0000 [thread overview]
Message-ID: <20030619203831.GB2379@nevyn.them.org> (raw)
In-Reply-To: <3EEF7B90.1020700@redhat.com>
On Tue, Jun 17, 2003 at 04:35:28PM -0400, Andrew Cagney wrote:
> >+ default:
> >+ warning ("Internal error, %s line %d.", __FILE__, __LINE__);
> >+ break;
>
> Please, no. If its an internal error, call internal_error.
I was just moving old code around. But I've fixed it.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
2003-06-19 Daniel Jacobowitz <drow@mvista.com>
* breakpoint.c (insert_catchpoint): Call internal_error.
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.123
diff -u -p -r1.123 breakpoint.c
--- breakpoint.c 17 Jun 2003 19:17:59 -0000 1.123
+++ breakpoint.c 19 Jun 2003 20:01:46 -0000
@@ -722,7 +722,7 @@ insert_catchpoint (struct ui_out *uo, vo
val = target_insert_exec_catchpoint (PIDGET (inferior_ptid));
break;
default:
- warning ("Internal error, %s line %d.", __FILE__, __LINE__);
+ internal_error (__FILE__, __LINE__, "unknown breakpoint type");
break;
}
prev parent reply other threads:[~2003-06-19 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-17 19:46 Daniel Jacobowitz
2003-06-17 20:41 ` Andrew Cagney
2003-06-19 20:38 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030619203831.GB2379@nevyn.them.org \
--to=drow@mvista.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox