From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17204 invoked by alias); 19 Jun 2003 20:38:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17192 invoked from network); 19 Jun 2003 20:38:37 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 19 Jun 2003 20:38:37 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19T6Bq-0002AC-00; Thu, 19 Jun 2003 15:39:26 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19T6Ay-0006rs-00; Thu, 19 Jun 2003 16:38:32 -0400 Date: Thu, 19 Jun 2003 20:38:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] Fix new failures in break.exp Message-ID: <20030619203831.GB2379@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb-patches@sources.redhat.com References: <20030617191954.GA17838@nevyn.them.org> <3EEF7B90.1020700@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EEF7B90.1020700@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-06/txt/msg00640.txt.bz2 On Tue, Jun 17, 2003 at 04:35:28PM -0400, Andrew Cagney wrote: > >+ default: > >+ warning ("Internal error, %s line %d.", __FILE__, __LINE__); > >+ break; > > Please, no. If its an internal error, call internal_error. I was just moving old code around. But I've fixed it. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2003-06-19 Daniel Jacobowitz * breakpoint.c (insert_catchpoint): Call internal_error. Index: breakpoint.c =================================================================== RCS file: /cvs/src/src/gdb/breakpoint.c,v retrieving revision 1.123 diff -u -p -r1.123 breakpoint.c --- breakpoint.c 17 Jun 2003 19:17:59 -0000 1.123 +++ breakpoint.c 19 Jun 2003 20:01:46 -0000 @@ -722,7 +722,7 @@ insert_catchpoint (struct ui_out *uo, vo val = target_insert_exec_catchpoint (PIDGET (inferior_ptid)); break; default: - warning ("Internal error, %s line %d.", __FILE__, __LINE__); + internal_error (__FILE__, __LINE__, "unknown breakpoint type"); break; }