[RFA] Makefile.tpl: Add maybe-configure-itcl to configure-gdb

[RFA] Makefile.tpl: Add maybe-configure-itcl to configure-gdb

[Keith Seitz]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi,

Turns out this build problem has been around for a while. I wasn't
seeing it because I kept an installed version of our tools around. Sure
enough, as soon as I removed the installed version, there was the
problem.

Synopsis: do a "make configure-gdb" when you intend to build insight.
You won't get itcl configured, and consequently, insight won't build.

Keith

ChangeLog
2003-06-18  Keith Seitz  <kseitz@sources.redhat.com>

        * Makefile.tpl: Add maybe-configure-itcl to configure-gdb.
        * Makefile.in: Regenerate.



[-- Attachment #2: itcl.patch --]
[-- Type: text/x-patch, Size: 903 bytes --]

Index: Makefile.tpl
===================================================================
RCS file: /cvs/src/src/Makefile.tpl,v
retrieving revision 1.71
diff -u -p -r1.71 Makefile.tpl
--- Makefile.tpl	17 Jun 2003 21:59:09 -0000	1.71
+++ Makefile.tpl	18 Jun 2003 21:11:24 -0000
@@ -1353,7 +1353,7 @@ all-bootstrap: maybe-all-libiberty maybe
 
 # Host modules specific to gdb.
 # GDB needs to know that the simulator is being built.
-configure-gdb: maybe-configure-tcl maybe-configure-tk maybe-configure-sim
+configure-gdb: maybe-configure-itcl maybe-configure-tcl maybe-configure-tk maybe-configure-sim
 GDB_TK = @GDB_TK@
 all-gdb: maybe-all-libiberty maybe-all-opcodes maybe-all-bfd maybe-all-mmalloc maybe-all-readline maybe-all-bison maybe-all-byacc maybe-all-sim $(gdbnlmrequirements) $(GDB_TK)
 install-gdb: maybe-install-tcl maybe-install-tk maybe-install-itcl maybe-install-tix maybe-install-libgui

Re: [RFA] Makefile.tpl: Add maybe-configure-itcl to configure-gdb

[Daniel Jacobowitz]

On Wed, Jun 18, 2003 at 02:24:48PM -0700, Keith Seitz wrote:
> Hi,
> 
> Turns out this build problem has been around for a while. I wasn't
> seeing it because I kept an installed version of our tools around. Sure
> enough, as soon as I removed the installed version, there was the
> problem.
> 
> Synopsis: do a "make configure-gdb" when you intend to build insight.
> You won't get itcl configured, and consequently, insight won't build.

This is OK.  It should be committed in gcc/ at the same time; if you
don't have write access I guess DJ's sync scripts will pick it up?

> 
> Keith
> 
> ChangeLog
> 2003-06-18  Keith Seitz  <kseitz@sources.redhat.com>
> 
>         * Makefile.tpl: Add maybe-configure-itcl to configure-gdb.
>         * Makefile.in: Regenerate.
> 
> 

> Index: Makefile.tpl
> ===================================================================
> RCS file: /cvs/src/src/Makefile.tpl,v
> retrieving revision 1.71
> diff -u -p -r1.71 Makefile.tpl
> --- Makefile.tpl	17 Jun 2003 21:59:09 -0000	1.71
> +++ Makefile.tpl	18 Jun 2003 21:11:24 -0000
> @@ -1353,7 +1353,7 @@ all-bootstrap: maybe-all-libiberty maybe
>  
>  # Host modules specific to gdb.
>  # GDB needs to know that the simulator is being built.
> -configure-gdb: maybe-configure-tcl maybe-configure-tk maybe-configure-sim
> +configure-gdb: maybe-configure-itcl maybe-configure-tcl maybe-configure-tk maybe-configure-sim
>  GDB_TK = @GDB_TK@
>  all-gdb: maybe-all-libiberty maybe-all-opcodes maybe-all-bfd maybe-all-mmalloc maybe-all-readline maybe-all-bison maybe-all-byacc maybe-all-sim $(gdbnlmrequirements) $(GDB_TK)
>  install-gdb: maybe-install-tcl maybe-install-tk maybe-install-itcl maybe-install-tix maybe-install-libgui


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA] Makefile.tpl: Add maybe-configure-itcl to configure-gdb

[Keith Seitz]

On Wed, 2003-06-18 at 14:27, Daniel Jacobowitz wrote:

> This is OK.  It should be committed in gcc/ at the same time; if you
> don't have write access I guess DJ's sync scripts will pick it up?

I do not have access to gcc.

Aside: I presume the MAINTAINERS file needs to be updated so that it
mentions Makefile.tpl and the real procedure for getting patches to it
approved...

Keith

Re: [RFA] Makefile.tpl: Add maybe-configure-itcl to configure-gdb

[DJ Delorie]

> I do not have access to gcc.

I'll apply the patches when I see them.

> Aside: I presume the MAINTAINERS file needs to be updated so that it
> mentions Makefile.tpl and the real procedure for getting patches to
> it approved...

The "real procedure" has never been approved.  The sync only works
because there's enough people who happen to have the right privs in
the right projects to make it happen manually.

Re: [RFA] Makefile.tpl: Add maybe-configure-itcl to configure-gdb

[DJ Delorie]

> This is OK.  It should be committed in gcc/ at the same time; if you
> don't have write access I guess DJ's sync scripts will pick it up?

My scripts notice that there's a difference, but they still have to be
manually applied.

Re: [RFA] Makefile.tpl: Add maybe-configure-itcl to configure-gdb

[Keith Seitz]

On Wed, 2003-06-18 at 14:24, Keith Seitz wrote:
> ChangeLog
> 2003-06-18  Keith Seitz  <kseitz@sources.redhat.com>
> 
>         * Makefile.tpl: Add maybe-configure-itcl to configure-gdb.
>         * Makefile.in: Regenerate.

I've committed this patch.

Keith

[6.0 PATCH] Makefile.tpl: Add maybe-configure-itcl to configure-gdb

[Keith Seitz]

On Wed, 2003-06-18 at 14:24, Keith Seitz wrote:
> ChangeLog
> 2003-06-18  Keith Seitz  <kseitz@sources.redhat.com>
> 
>         * Makefile.tpl: Add maybe-configure-itcl to configure-gdb.
>         * Makefile.in: Regenerate.

I've committed the same patch to the 6.0 branch.

Thanks to Andrew for the reminder.

Keith