[RFA] Fallback unsupported languages to "minimal"

[RFA] Fallback unsupported languages to "minimal"

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Now that we have the "minimal" language, we can change the DWARF2 reader
to fallback to this language, instead of using the "unknown" one.

See http://sources.redhat.com/ml/gdb-patches/2003-04/msg00112.html for
more details.

2002-05-08  J. Brobecker  <brobecker@gnat.com>

        * set_cu_language: Set the language to "minimal" if the language
        of the CU is not currently supported by GDB.

Seems kind of obvious, but it never hurts to ask. Ok to apply?

-- 
Joel

[-- Attachment #2: dw2.diff --]
[-- Type: text/plain, Size: 742 bytes --]

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.91
diff -c -3 -p -r1.91 dwarf2read.c
*** dwarf2read.c	7 May 2003 22:57:30 -0000	1.91
--- dwarf2read.c	8 May 2003 17:39:56 -0000
*************** set_cu_language (unsigned int lang)
*** 4548,4554 ****
      case DW_LANG_Pascal83:
      case DW_LANG_Modula2:
      default:
!       cu_language = language_unknown;
        break;
      }
    cu_language_defn = language_def (cu_language);
--- 4548,4554 ----
      case DW_LANG_Pascal83:
      case DW_LANG_Modula2:
      default:
!       cu_language = language_minimal;
        break;
      }
    cu_language_defn = language_def (cu_language);

Re: [RFA] Fallback unsupported languages to "minimal"

[Daniel Jacobowitz]

On Thu, May 08, 2003 at 10:46:52AM -0700, Joel Brobecker wrote:
> Now that we have the "minimal" language, we can change the DWARF2 reader
> to fallback to this language, instead of using the "unknown" one.
> 
> See http://sources.redhat.com/ml/gdb-patches/2003-04/msg00112.html for
> more details.
> 
> 2002-05-08  J. Brobecker  <brobecker@gnat.com>
> 
>         * set_cu_language: Set the language to "minimal" if the language
>         of the CU is not currently supported by GDB.

Tsk tsk, changelog formatting :)  dwarf2read.c (set_cu_language).

> Seems kind of obvious, but it never hurts to ask. Ok to apply?

> Index: dwarf2read.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/dwarf2read.c,v
> retrieving revision 1.91
> diff -c -3 -p -r1.91 dwarf2read.c
> *** dwarf2read.c	7 May 2003 22:57:30 -0000	1.91
> --- dwarf2read.c	8 May 2003 17:39:56 -0000
> *************** set_cu_language (unsigned int lang)
> *** 4548,4554 ****
>       case DW_LANG_Pascal83:
>       case DW_LANG_Modula2:
>       default:
> !       cu_language = language_unknown;
>         break;
>       }
>     cu_language_defn = language_def (cu_language);
> --- 4548,4554 ----
>       case DW_LANG_Pascal83:
>       case DW_LANG_Modula2:
>       default:
> !       cu_language = language_minimal;
>         break;
>       }
>     cu_language_defn = language_def (cu_language);


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA] Fallback unsupported languages to "minimal"

[Elena Zannoni]

Joel Brobecker writes:
 > Now that we have the "minimal" language, we can change the DWARF2 reader
 > to fallback to this language, instead of using the "unknown" one.
 > 
 > See http://sources.redhat.com/ml/gdb-patches/2003-04/msg00112.html for
 > more details.
 > 
 > 2002-05-08  J. Brobecker  <brobecker@gnat.com>
 > 
 >         * set_cu_language: Set the language to "minimal" if the language
 >         of the CU is not currently supported by GDB.
 > 
 > Seems kind of obvious, but it never hurts to ask. Ok to apply?
 > 

yes.

elena


 > -- 
 > Joel
 > Index: dwarf2read.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/dwarf2read.c,v
 > retrieving revision 1.91
 > diff -c -3 -p -r1.91 dwarf2read.c
 > *** dwarf2read.c	7 May 2003 22:57:30 -0000	1.91
 > --- dwarf2read.c	8 May 2003 17:39:56 -0000
 > *************** set_cu_language (unsigned int lang)
 > *** 4548,4554 ****
 >       case DW_LANG_Pascal83:
 >       case DW_LANG_Modula2:
 >       default:
 > !       cu_language = language_unknown;
 >         break;
 >       }
 >     cu_language_defn = language_def (cu_language);
 > --- 4548,4554 ----
 >       case DW_LANG_Pascal83:
 >       case DW_LANG_Modula2:
 >       default:
 > !       cu_language = language_minimal;
 >         break;
 >       }
 >     cu_language_defn = language_def (cu_language);

Re: [RFA] Fallback unsupported languages to "minimal"

[Joel Brobecker]

>  > 2002-05-08  J. Brobecker  <brobecker@gnat.com>
>  > 
>  >         * set_cu_language: Set the language to "minimal" if the language
>  >         of the CU is not currently supported by GDB.
>  > 
>  > Seems kind of obvious, but it never hurts to ask. Ok to apply?
>  > 
> 
> yes.

Thanks, it's in (with the ChangeLog correction spotted by Daniel J, thanks!)

-- 
Joel