Re: [RFA/TESTSUITE] build schedlock.c on 64-bit platforms

[Daniel Jacobowitz <drow@mvista.com>]

On Thu, Apr 10, 2003 at 10:12:28AM -0400, Elena Zannoni wrote:
> Daniel Jacobowitz writes:
>  > On Tue, Apr 08, 2003 at 05:20:19PM -0400, Elena Zannoni wrote:
>  > > 
>  > > I was getting warnings when compiling the test on 64-bit because of the casts.
>  > > 
> 
>  > 
>  > Sigh, I was just sloppy writing this one.   Does it work if you pass
>  > &args[i] instead of messing with my_number?  That's a little more
>  > portable.
>  > 
> 
> Ok, how about this? But now get_current_thread in schedlock.exp
> doesn't work, because the output has changed. I am not sure I
> understand what it should be doing now. There is no way to get the
> thread number from the backtraces.

Oh, you're right - sorry for the wild goose chase.  I think your
previous patch with the cast to long is OK then.  The test isn't
terribly portable but it should be portable enough for our use.

> 
> elena
> 
> 
> 
> 
> Index: schedlock.c
> ===================================================================
> RCS file: /cvs/uberbaum/gdb/testsuite/gdb.threads/schedlock.c,v
> retrieving revision 1.2
> diff -u -p -r1.2 schedlock.c
> --- schedlock.c	23 Oct 2002 03:22:56 -0000	1.2
> +++ schedlock.c	10 Apr 2003 14:00:41 -0000
> @@ -18,19 +18,21 @@ int main() {
>      for (i = 0; i < NUM; i++)
>        {
>  	args[i] = 1;
> -	res = pthread_create(&threads[i], NULL, thread_function, (void *)i);
> +	res = pthread_create(&threads[i],
> +		             NULL,
> +			     thread_function,
> +			     (void *) &args[i]);
>        }
>  
>      /* schedlock.exp: last thread start.  */
>      args[i] = 1;
> -    thread_function ((void *) i);
> +    thread_function ((void *) &args[i]);
>  
>      exit(EXIT_SUCCESS);
>  }
>  
>  void *thread_function(void *arg) {
> -    int my_number = (int) arg;
> -    int *myp = &args[my_number];
> +    int *myp = (int *)arg;
>  
>      /* Don't run forever.  Run just short of it :)  */
>      while (*myp > 0)
> 
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer