* [RFA/doco] Adjust the normal_stop observer documentation
@ 2003-03-31 23:06 Joel Brobecker
2003-03-31 23:17 ` Daniel Jacobowitz
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Joel Brobecker @ 2003-03-31 23:06 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
Hello,
The normal_stop notification has been inserted in a slightly different
location than the location I had in mind. As a consequence, the
description for this notification needed to be slightly adjusted. I took
this opportunity to fix a minor nit (same word repeated twice).
2003-03-31 J. Brobecker <brobecker@gnat.com>
* observer.texi (GDB Observers): Adjust the documentation for the
normal_stop notification to better describe reality. Fix a minor
typo.
Ok to apply?
Thanks,
--
Joel
[-- Attachment #2: observer.texi.diff --]
[-- Type: text/plain, Size: 1958 bytes --]
Index: observer.texi
===================================================================
RCS file: /cvs/src/src/gdb/doc/observer.texi,v
retrieving revision 1.1
diff -c -3 -r1.1 observer.texi
*** observer.texi 18 Mar 2003 17:44:23 -0000 1.1
--- observer.texi 31 Mar 2003 22:56:30 -0000
***************
*** 27,33 ****
callback is detached. This is not a problem so far, as this contextual
data is only used internally to hold a function pointer. Later on, if
a certain observer needs to provide support for user-level contextual
! data, then the generic notification mechanism will need need to be
enhanced to allow the observer to provide a routine to deallocate the
data when attaching the callback.
--- 27,33 ----
callback is detached. This is not a problem so far, as this contextual
data is only used internally to hold a function pointer. Later on, if
a certain observer needs to provide support for user-level contextual
! data, then the generic notification mechanism will need to be
enhanced to allow the observer to provide a routine to deallocate the
data when attaching the callback.
***************
*** 40,48 ****
@cindex notification about inferior execution stop
@value{GDBN} will notify all @code{normal_stop} observers when the
! inferior execution has just stopped, and all the associated internal
! processing (such as breakpoint commands, annotations, etc) is about to
! be performed before the @value{GDBN} prompt is returned to the user.
The following interface is available to manage @code{normal_stop}
observers:
--- 40,48 ----
@cindex notification about inferior execution stop
@value{GDBN} will notify all @code{normal_stop} observers when the
! inferior execution has just stopped, the associated messages and
! annotations have been printed, and the control is about to be returned
! to the user.
The following interface is available to manage @code{normal_stop}
observers:
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA/doco] Adjust the normal_stop observer documentation
2003-03-31 23:06 [RFA/doco] Adjust the normal_stop observer documentation Joel Brobecker
@ 2003-03-31 23:17 ` Daniel Jacobowitz
2003-03-31 23:29 ` Joel Brobecker
2003-04-01 1:00 ` Joel Brobecker
2003-04-01 3:27 ` Eli Zaretskii
2 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-03-31 23:17 UTC (permalink / raw)
To: gdb-patches
On Mon, Mar 31, 2003 at 03:05:56PM -0800, Joel Brobecker wrote:
> Hello,
>
> The normal_stop notification has been inserted in a slightly different
> location than the location I had in mind. As a consequence, the
> description for this notification needed to be slightly adjusted. I took
> this opportunity to fix a minor nit (same word repeated twice).
> ***************
> *** 40,48 ****
> @cindex notification about inferior execution stop
>
> @value{GDBN} will notify all @code{normal_stop} observers when the
> ! inferior execution has just stopped, and all the associated internal
> ! processing (such as breakpoint commands, annotations, etc) is about to
> ! be performed before the @value{GDBN} prompt is returned to the user.
>
> The following interface is available to manage @code{normal_stop}
> observers:
> --- 40,48 ----
> @cindex notification about inferior execution stop
>
> @value{GDBN} will notify all @code{normal_stop} observers when the
> ! inferior execution has just stopped, the associated messages and
> ! annotations have been printed, and the control is about to be returned
> ! to the user.
>
> The following interface is available to manage @code{normal_stop}
> observers:
Have user breakpoint commands been executed at this point? How about
breakpoint conditions? If so, it suggests that the cache management
you wanted for Ada needs to be done at an earlier observation point,
perhaps corresponding to each _actual_ stop as opposed to each user
visible stop. Otherwise "info tasks" in a breakpoint commands list may
behave strangely...
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA/doco] Adjust the normal_stop observer documentation
2003-03-31 23:17 ` Daniel Jacobowitz
@ 2003-03-31 23:29 ` Joel Brobecker
0 siblings, 0 replies; 6+ messages in thread
From: Joel Brobecker @ 2003-03-31 23:29 UTC (permalink / raw)
To: gdb-patches
> Have user breakpoint commands been executed at this point? How about
> breakpoint conditions? If so, it suggests that the cache management
> you wanted for Ada needs to be done at an earlier observation point,
> perhaps corresponding to each _actual_ stop as opposed to each user
> visible stop. Otherwise "info tasks" in a breakpoint commands list may
> behave strangely...
Hmmm, the documentation should definitely include this information,
so the patch is withdrawn. I believe that the stop occurs before the
commands, but I need to double-check this. Regarding the breakpoint
conditions, I am not sure, I think the notification is occuring after
the condition is evaluated, but will also double-check.
Thanks for the comments!
--
Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA/doco] Adjust the normal_stop observer documentation
2003-03-31 23:06 [RFA/doco] Adjust the normal_stop observer documentation Joel Brobecker
2003-03-31 23:17 ` Daniel Jacobowitz
@ 2003-04-01 1:00 ` Joel Brobecker
2003-04-01 3:27 ` Eli Zaretskii
2 siblings, 0 replies; 6+ messages in thread
From: Joel Brobecker @ 2003-04-01 1:00 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
> 2003-03-31 J. Brobecker <brobecker@gnat.com>
>
> * observer.texi (GDB Observers): Adjust the documentation for the
> normal_stop notification to better describe reality. Fix a minor
> typo.
Second attempt, including Daniel's suggestion to document when the
breakpoint conditions and commands are evaluated relative to the
moment the normal_stop event is emitted.
The normal_stop notification has been inserted in a slightly different
location than the location I had in mind. As a consequence, the
description for this notification needed to be slightly adjusted. I took
this opportunity to fix a couple of minor nits.
New changelog:
2003-03-31 J. Brobecker <brobecker@gnat.com>
* observer.texi (GDB Observers): Adjust the documentation for the
normal_stop notification to better describe reality. Fix a couple
of minor typos.
--
Joel
[-- Attachment #2: observer.texi.diff --]
[-- Type: text/plain, Size: 2976 bytes --]
Index: observer.texi
===================================================================
RCS file: /cvs/src/src/gdb/doc/observer.texi,v
retrieving revision 1.1
diff -c -3 -r1.1 observer.texi
*** observer.texi 18 Mar 2003 17:44:23 -0000 1.1
--- observer.texi 1 Apr 2003 00:53:00 -0000
***************
*** 12,18 ****
One subject can have several observers.
@file{observer.c} implements an internal generic low-level event
! notification mechanism. This generic event notification mechansim is
then re-used to implement the exported high-level notification
management routines for all possible notifications.
--- 12,18 ----
One subject can have several observers.
@file{observer.c} implements an internal generic low-level event
! notification mechanism. This generic event notification mechanism is
then re-used to implement the exported high-level notification
management routines for all possible notifications.
***************
*** 27,33 ****
callback is detached. This is not a problem so far, as this contextual
data is only used internally to hold a function pointer. Later on, if
a certain observer needs to provide support for user-level contextual
! data, then the generic notification mechanism will need need to be
enhanced to allow the observer to provide a routine to deallocate the
data when attaching the callback.
--- 27,33 ----
callback is detached. This is not a problem so far, as this contextual
data is only used internally to hold a function pointer. Later on, if
a certain observer needs to provide support for user-level contextual
! data, then the generic notification mechanism will need to be
enhanced to allow the observer to provide a routine to deallocate the
data when attaching the callback.
***************
*** 39,48 ****
@cindex @code{normal_stop} observer
@cindex notification about inferior execution stop
! @value{GDBN} will notify all @code{normal_stop} observers when the
! inferior execution has just stopped, and all the associated internal
! processing (such as breakpoint commands, annotations, etc) is about to
! be performed before the @value{GDBN} prompt is returned to the user.
The following interface is available to manage @code{normal_stop}
observers:
--- 39,54 ----
@cindex @code{normal_stop} observer
@cindex notification about inferior execution stop
! @value{GDBN} notifies all @code{normal_stop} observers when the
! inferior execution has just stopped, the associated messages and
! annotations have been printed, and the control is about to be returned
! to the user.
!
! Note that the @code{normal_stop} notification is not emitted when
! the execution stops due to a breakpoint, and this breakpoint has
! a condition that is not met. If the breakpoint has any associated
! commands list, the commands are executed after the notification
! is emitted.
The following interface is available to manage @code{normal_stop}
observers:
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA/doco] Adjust the normal_stop observer documentation
2003-03-31 23:06 [RFA/doco] Adjust the normal_stop observer documentation Joel Brobecker
2003-03-31 23:17 ` Daniel Jacobowitz
2003-04-01 1:00 ` Joel Brobecker
@ 2003-04-01 3:27 ` Eli Zaretskii
2003-04-03 15:15 ` Joel Brobecker
2 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2003-04-01 3:27 UTC (permalink / raw)
To: brobecker; +Cc: gdb-patches
> Date: Mon, 31 Mar 2003 15:05:56 -0800
> From: Joel Brobecker <brobecker@gnat.com>
>
> The normal_stop notification has been inserted in a slightly different
> location than the location I had in mind. As a consequence, the
> description for this notification needed to be slightly adjusted. I took
> this opportunity to fix a minor nit (same word repeated twice).
>
> 2003-03-31 J. Brobecker <brobecker@gnat.com>
>
> * observer.texi (GDB Observers): Adjust the documentation for the
> normal_stop notification to better describe reality. Fix a minor
> typo.
>
> Ok to apply?
Yes, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA/doco] Adjust the normal_stop observer documentation
2003-04-01 3:27 ` Eli Zaretskii
@ 2003-04-03 15:15 ` Joel Brobecker
0 siblings, 0 replies; 6+ messages in thread
From: Joel Brobecker @ 2003-04-03 15:15 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: gdb-patches
> > 2003-03-31 J. Brobecker <brobecker@gnat.com>
> >
> > * observer.texi (GDB Observers): Adjust the documentation for the
> > normal_stop notification to better describe reality. Fix a minor
> > typo.
> >
> > Ok to apply?
>
> Yes, thanks.
Thank you, checked in.
--
Joel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-04-03 15:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-31 23:06 [RFA/doco] Adjust the normal_stop observer documentation Joel Brobecker
2003-03-31 23:17 ` Daniel Jacobowitz
2003-03-31 23:29 ` Joel Brobecker
2003-04-01 1:00 ` Joel Brobecker
2003-04-01 3:27 ` Eli Zaretskii
2003-04-03 15:15 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox