Re: [RFA] testsuite/gdb.c++/casts.exp: Fix to run also on embedded targets

Re: [RFA] testsuite/gdb.c++/casts.exp: Fix to run also on embedded targets

[Michael Elizabeth Chastain]

> the following patch removes the usage of the "run" command from the
> gdb.c++/casts.exp test.  This way it also runs on targets which don't
> support "run" as a valid command (e.g. on embedded boards).
> 
> Ok to commit?

Hi Corinna,

Approved, provided you've tested it at least once.

Any similar patches from you in gdb.c++ are pre-approved,
as long as you say that you've tested them.

Michael C

2003-03-27  Corinna Vinschen  <vinschen@redhat.com>

	* gdb.c++/casts.exp: Fix startup to run also on embedded targets.

Re: [RFA] testsuite/gdb.c++/casts.exp: Fix to run also on embedded targets

[Corinna Vinschen]

On Thu, Mar 27, 2003 at 12:09:44PM -0600, Michael Elizabeth Chastain wrote:
> > the following patch removes the usage of the "run" command from the
> > gdb.c++/casts.exp test.  This way it also runs on targets which don't
> > support "run" as a valid command (e.g. on embedded boards).
> > 
> > Ok to commit?
> 
> Hi Corinna,
> 
> Approved, provided you've tested it at least once.

Yes, sure, it's tested.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com

[RFA] testsuite/gdb.c++/casts.exp: Fix to run also on embedded targets

[Corinna Vinschen]

Hi,

the following patch removes the usage of the "run" command from the
gdb.c++/casts.exp test.  This way it also runs on targets which don't
support "run" as a valid command (e.g. on embedded boards).

Ok to commit?

2003-03-27  Corinna Vinschen  <vinschen@redhat.com>

	* gdb.c++/casts.exp: Fix startup to run also on embedded targets.

Index: gdb.c++/casts.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.c++/casts.exp,v
retrieving revision 1.2
diff -u -p -r1.2 casts.exp
--- gdb.c++/casts.exp	4 Jan 2003 22:30:21 -0000	1.2
+++ gdb.c++/casts.exp	27 Mar 2003 09:38:52 -0000
@@ -55,11 +55,16 @@ gdb_start
 gdb_reinitialize_dir $srcdir/$subdir
 gdb_load ${binfile}
 
+if ![runto_main] then {
+    perror "couldn't run to breakpoint"
+    continue
+}
+
 gdb_test "break [gdb_get_line_number "casts.exp: 1"]" \
     "Breakpoint.*at.* file .*" \
     ""
 
-gdb_test "run" "Breakpoint .* at .*casts.cc.*" ""
+gdb_test "continue" "Breakpoint .* at .*casts.cc.*" ""
 
 # Casting a pointer to a base class to a pointer to a derived class
 # should yield the entire derived class.  Until August 2002, GDB got


-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com

Re: [RFA] testsuite/gdb.c++/casts.exp: Fix to run also on embedded targets

[Daniel Jacobowitz]

On Thu, Mar 27, 2003 at 10:50:59AM +0100, Corinna Vinschen wrote:
> Hi,
> 
> the following patch removes the usage of the "run" command from the
> gdb.c++/casts.exp test.  This way it also runs on targets which don't
> support "run" as a valid command (e.g. on embedded boards).
> 
> Ok to commit?

Yes, this is OK.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA] testsuite/gdb.c++/casts.exp: Fix to run also on embedded targets

[Corinna Vinschen]

On Thu, Mar 27, 2003 at 08:40:13AM -0500, Daniel Jacobowitz wrote:
> On Thu, Mar 27, 2003 at 10:50:59AM +0100, Corinna Vinschen wrote:
> > Hi,
> > 
> > the following patch removes the usage of the "run" command from the
> > gdb.c++/casts.exp test.  This way it also runs on targets which don't
> > support "run" as a valid command (e.g. on embedded boards).
> > 
> > Ok to commit?
> 
> Yes, this is OK.

Thanks, applied.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com