From: Joel Brobecker <brobecker@gnat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Add observer notification in normal_stop
Date: Tue, 18 Mar 2003 18:22:00 -0000 [thread overview]
Message-ID: <20030318182254.GT16507@gnat.com> (raw)
In-Reply-To: <3E774057.50209@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
> I think down the end, next to the annotate_stop() call, would be better.
Yes, makes sense, new patch attached.
> I'm assuming that the secret agenda is to replace all annotate_xxx() and
> xxx_hook() calls with a equivalent observer_notify_xxx() call. Hence,
> adding an observer_xxx() call where ever either of the former appears
> should be pretty obvious and largely mechanical.
That'd be nice.
2003-03-18 J. Brobecker <brobecker@gnat.com>
* infrun.c (observer.h): Add #include.
(normal_stop): Add call to observer_notify_normal_stop.
* Makefile.in (infrun.o): Add dependency on observer.h.
--
Joel
[-- Attachment #2: infrun.diff --]
[-- Type: text/plain, Size: 1983 bytes --]
Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.97
diff -c -3 -p -r1.97 infrun.c
*** infrun.c 24 Feb 2003 21:56:49 -0000 1.97
--- infrun.c 18 Mar 2003 18:10:10 -0000
***************
*** 42,47 ****
--- 42,48 ----
#include "inf-loop.h"
#include "regcache.h"
#include "value.h"
+ #include "observer.h"
/* Prototypes for local functions */
*************** normal_stop (void)
*** 3113,3118 ****
--- 3114,3120 ----
done:
annotate_stopped ();
+ observer_notify_normal_stop ();
}
static int
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.342
diff -c -3 -p -r1.342 Makefile.in
*** Makefile.in 17 Mar 2003 23:25:08 -0000 1.342
--- Makefile.in 18 Mar 2003 18:10:12 -0000
*************** infptrace.o: infptrace.c $(defs_h) $(fra
*** 1817,1823 ****
infrun.o: infrun.c $(defs_h) $(gdb_string_h) $(symtab_h) $(frame_h) \
$(inferior_h) $(breakpoint_h) $(gdb_wait_h) $(gdbcore_h) $(gdbcmd_h) \
$(cli_script_h) $(target_h) $(gdbthread_h) $(annotate_h) \
! $(symfile_h) $(top_h) $(inf_loop_h) $(regcache_h) $(value_h)
inftarg.o: inftarg.c $(defs_h) $(frame_h) $(inferior_h) $(target_h) \
$(gdbcore_h) $(command_h) $(gdb_stat_h) $(gdb_wait_h) $(inflow_h)
infttrace.o: infttrace.c $(defs_h) $(frame_h) $(inferior_h) $(target_h) \
--- 1817,1824 ----
infrun.o: infrun.c $(defs_h) $(gdb_string_h) $(symtab_h) $(frame_h) \
$(inferior_h) $(breakpoint_h) $(gdb_wait_h) $(gdbcore_h) $(gdbcmd_h) \
$(cli_script_h) $(target_h) $(gdbthread_h) $(annotate_h) \
! $(symfile_h) $(top_h) $(inf_loop_h) $(regcache_h) $(value_h) \
! $(observer_h)
inftarg.o: inftarg.c $(defs_h) $(frame_h) $(inferior_h) $(target_h) \
$(gdbcore_h) $(command_h) $(gdb_stat_h) $(gdb_wait_h) $(inflow_h)
infttrace.o: infttrace.c $(defs_h) $(frame_h) $(inferior_h) $(target_h) \
next prev parent reply other threads:[~2003-03-18 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-18 1:49 Joel Brobecker
2003-03-18 1:51 ` Joel Brobecker
2003-03-18 15:50 ` Andrew Cagney
2003-03-18 18:22 ` Joel Brobecker [this message]
2003-03-18 19:00 ` Andrew Cagney
2003-03-18 19:07 ` Joel Brobecker
2003-03-18 19:12 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030318182254.GT16507@gnat.com \
--to=brobecker@gnat.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox