From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1581 invoked by alias); 18 Mar 2003 18:22:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1436 invoked from network); 18 Mar 2003 18:22:51 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 18 Mar 2003 18:22:51 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 40685D34B8; Tue, 18 Mar 2003 10:22:54 -0800 (PST) Date: Tue, 18 Mar 2003 18:22:00 -0000 From: Joel Brobecker To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Add observer notification in normal_stop Message-ID: <20030318182254.GT16507@gnat.com> References: <20030318014944.GJ16507@gnat.com> <20030318015112.GK16507@gnat.com> <3E774057.50209@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="ulDeV4rPMk/y39in" Content-Disposition: inline In-Reply-To: <3E774057.50209@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2003-03/txt/msg00404.txt.bz2 --ulDeV4rPMk/y39in Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 640 > I think down the end, next to the annotate_stop() call, would be better. Yes, makes sense, new patch attached. > I'm assuming that the secret agenda is to replace all annotate_xxx() and > xxx_hook() calls with a equivalent observer_notify_xxx() call. Hence, > adding an observer_xxx() call where ever either of the former appears > should be pretty obvious and largely mechanical. That'd be nice. 2003-03-18 J. Brobecker * infrun.c (observer.h): Add #include. (normal_stop): Add call to observer_notify_normal_stop. * Makefile.in (infrun.o): Add dependency on observer.h. -- Joel --ulDeV4rPMk/y39in Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="infrun.diff" Content-length: 1983 Index: infrun.c =================================================================== RCS file: /cvs/src/src/gdb/infrun.c,v retrieving revision 1.97 diff -c -3 -p -r1.97 infrun.c *** infrun.c 24 Feb 2003 21:56:49 -0000 1.97 --- infrun.c 18 Mar 2003 18:10:10 -0000 *************** *** 42,47 **** --- 42,48 ---- #include "inf-loop.h" #include "regcache.h" #include "value.h" + #include "observer.h" /* Prototypes for local functions */ *************** normal_stop (void) *** 3113,3118 **** --- 3114,3120 ---- done: annotate_stopped (); + observer_notify_normal_stop (); } static int Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.342 diff -c -3 -p -r1.342 Makefile.in *** Makefile.in 17 Mar 2003 23:25:08 -0000 1.342 --- Makefile.in 18 Mar 2003 18:10:12 -0000 *************** infptrace.o: infptrace.c $(defs_h) $(fra *** 1817,1823 **** infrun.o: infrun.c $(defs_h) $(gdb_string_h) $(symtab_h) $(frame_h) \ $(inferior_h) $(breakpoint_h) $(gdb_wait_h) $(gdbcore_h) $(gdbcmd_h) \ $(cli_script_h) $(target_h) $(gdbthread_h) $(annotate_h) \ ! $(symfile_h) $(top_h) $(inf_loop_h) $(regcache_h) $(value_h) inftarg.o: inftarg.c $(defs_h) $(frame_h) $(inferior_h) $(target_h) \ $(gdbcore_h) $(command_h) $(gdb_stat_h) $(gdb_wait_h) $(inflow_h) infttrace.o: infttrace.c $(defs_h) $(frame_h) $(inferior_h) $(target_h) \ --- 1817,1824 ---- infrun.o: infrun.c $(defs_h) $(gdb_string_h) $(symtab_h) $(frame_h) \ $(inferior_h) $(breakpoint_h) $(gdb_wait_h) $(gdbcore_h) $(gdbcmd_h) \ $(cli_script_h) $(target_h) $(gdbthread_h) $(annotate_h) \ ! $(symfile_h) $(top_h) $(inf_loop_h) $(regcache_h) $(value_h) \ ! $(observer_h) inftarg.o: inftarg.c $(defs_h) $(frame_h) $(inferior_h) $(target_h) \ $(gdbcore_h) $(command_h) $(gdb_stat_h) $(gdb_wait_h) $(inflow_h) infttrace.o: infttrace.c $(defs_h) $(frame_h) $(inferior_h) $(target_h) \ --ulDeV4rPMk/y39in--