From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA/hppa] Remove hack in hppa_push_dummy_frame...
Date: Tue, 18 Mar 2003 02:30:00 -0000 [thread overview]
Message-ID: <20030318023007.GN16507@gnat.com> (raw)
Hello,
A long time ago (that long already), I sent a question asking how to
rework a hack that was currently in place. Andrew looked at the code,
and wondered how it could possibly be working.
The probable answer is: it doesn't! I removed the code in question, and
rerun it through the testsuite, and did not see any regression.
This hack is causing me trouble for the multiarch conversion, and Andrew
mentionned that this was preventing him from making `struct frame_info'
opaque. I therefore suggest that we remove this code at once.
I am sure this code was there for something, and that some problem will
show up later, but I suggest we fix it then, and we fix it the proper
way.
2003-03-17 J. Brobecker <brobecker@gnat.com>
* hppa-tdep.c (hppa_push_dummy_frame): Remove hack which does not
appear to be working in any case.
The next will then to fix the profile of hppa_push_dummy_frame to remove
the dependency on struct inferior_status (by removing the now-unused
parameter), to make it conformant with the push_dummy_frame gdbarch method.
Ok to apply?
--
Joel
next reply other threads:[~2003-03-18 2:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-18 2:30 Joel Brobecker [this message]
2003-03-18 4:46 ` Andrew Cagney
2003-03-18 18:28 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030318023007.GN16507@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox