From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15790 invoked by alias); 18 Mar 2003 02:30:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15754 invoked from network); 18 Mar 2003 02:30:05 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 18 Mar 2003 02:30:05 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 0EF32D34B8; Mon, 17 Mar 2003 18:30:08 -0800 (PST) Date: Tue, 18 Mar 2003 02:30:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: [RFA/hppa] Remove hack in hppa_push_dummy_frame... Message-ID: <20030318023007.GN16507@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2003-03/txt/msg00388.txt.bz2 Hello, A long time ago (that long already), I sent a question asking how to rework a hack that was currently in place. Andrew looked at the code, and wondered how it could possibly be working. The probable answer is: it doesn't! I removed the code in question, and rerun it through the testsuite, and did not see any regression. This hack is causing me trouble for the multiarch conversion, and Andrew mentionned that this was preventing him from making `struct frame_info' opaque. I therefore suggest that we remove this code at once. I am sure this code was there for something, and that some problem will show up later, but I suggest we fix it then, and we fix it the proper way. 2003-03-17 J. Brobecker * hppa-tdep.c (hppa_push_dummy_frame): Remove hack which does not appear to be working in any case. The next will then to fix the profile of hppa_push_dummy_frame to remove the dependency on struct inferior_status (by removing the now-unused parameter), to make it conformant with the push_dummy_frame gdbarch method. Ok to apply? -- Joel