From: Daniel Jacobowitz <drow@mvista.com>
To: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] Prologue detection on x86-64
Date: Thu, 06 Mar 2003 23:10:00 -0000 [thread overview]
Message-ID: <20030306231007.GA9627@nevyn.them.org> (raw)
In-Reply-To: <3E67D22C.3030908@suse.cz>
On Thu, Mar 06, 2003 at 11:56:44PM +0100, Michal Ludvig wrote:
> Hi all,
> the attached patch moves prologue detection from x86_64_skip_prologue()
> to separate function, that could be reused later. I need this separate
> function to implement unwinding of functions without debug info.
>
> It's an almost obvious patch, I believe.
>
> OK to commit?
Just two things:
> +/* We will handle only functions beginning with:
> + 55 pushq %rbp
> + 48 89 e5 movq %rsp,%rbp */
Period and two spaces, please.
> +#define PROLOG_BUFSIZE 4
> +static int
> +x86_64_function_has_prologue (CORE_ADDR pc)
> +int x86_64_function_has_prologue (CORE_ADDR pc);
That's probably a warning. Static functions don't need to be
prototyped in the tdep.h file; this bit can just be omitted.
Other than that OK.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-03-06 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-06 22:56 Michal Ludvig
2003-03-06 23:10 ` Daniel Jacobowitz [this message]
2003-03-06 23:14 ` Michal Ludvig
[not found] ` <20030306232209.GA10007@nevyn.them.org>
2003-03-07 10:44 ` Michal Ludvig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030306231007.GA9627@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox