From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-23120-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 1189 invoked by alias); 6 Mar 2003 23:10:10 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 1181 invoked from network); 6 Mar 2003 23:10:09 -0000
Received: from unknown (HELO crack.them.org) (65.125.64.184)
  by 172.16.49.205 with SMTP; 6 Mar 2003 23:10:09 -0000
Received: from nevyn.them.org ([66.93.61.169] ident=mail)
	by crack.them.org with asmtp (Exim 3.12 #1 (Debian))
	id 18r6OR-0006dM-00
	for <gdb-patches@sources.redhat.com>; Thu, 06 Mar 2003 19:11:23 -0600
Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian))
	id 18r4V6-0002Vf-00
	for <gdb-patches@sources.redhat.com>; Thu, 06 Mar 2003 18:10:08 -0500
Date: Thu, 06 Mar 2003 23:10:00 -0000
From: Daniel Jacobowitz <drow@mvista.com>
To: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] Prologue detection on x86-64
Message-ID: <20030306231007.GA9627@nevyn.them.org>
Mail-Followup-To: GDB Patches <gdb-patches@sources.redhat.com>
References: <3E67D22C.3030908@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3E67D22C.3030908@suse.cz>
User-Agent: Mutt/1.5.1i
X-SW-Source: 2003-03/txt/msg00148.txt.bz2

On Thu, Mar 06, 2003 at 11:56:44PM +0100, Michal Ludvig wrote:
> Hi all,
> the attached patch moves prologue detection from x86_64_skip_prologue() 
> to separate function, that could be reused later. I need this separate 
> function to implement unwinding of functions without debug info.
> 
> It's an almost obvious patch, I believe.
> 
> OK to commit?

Just two things:

> +/* We will handle only functions beginning with:
> +   55          pushq %rbp
> +   48 89 e5    movq %rsp,%rbp */

Period and two spaces, please.

> +#define PROLOG_BUFSIZE 4
> +static int
> +x86_64_function_has_prologue (CORE_ADDR pc)


> +int x86_64_function_has_prologue (CORE_ADDR pc);

That's probably a warning.  Static functions don't need to be
prototyped in the tdep.h file; this bit can just be omitted.

Other than that OK.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer