From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] Modify gdb/Makefile.in to build observer.c
Date: Fri, 28 Feb 2003 07:34:00 -0000 [thread overview]
Message-ID: <20030228073413.GE6112@gnat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
I made the following changes in order to have observer.[hc] built
in GDB.
Since this unit is currently unused in GDB, I have considered not
linking in this observer.o. However, I think I've seen another recent
patch that is just about ready to benefit from this framework. So I
discarded this idea.
There is one variable that I don't quite understand; it's
HFILES_NO_SRCDIR. The comment ("Header files that need to have srcdir
added", sic) did not help me, so I wasn't sure that observer.h does
not need to be added to this list. Let me know if it should.
2003-02-27 J. Brobecker <brobecker@gnat.com>
* Makefile.in: Add rules to build and link in observer.o.
Ok to apply?
--
Joel
[-- Attachment #2: Makefile.in.diff --]
[-- Type: text/plain, Size: 2174 bytes --]
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.335
diff -c -3 -r1.335 Makefile.in
*** Makefile.in 21 Feb 2003 15:24:17 -0000 1.335
--- Makefile.in 28 Feb 2003 07:24:16 -0000
***************
*** 529,535 ****
mdebugread.c memattr.c mem-break.c minsyms.c mipsread.c \
nlmread.c \
objc-exp.y objc-lang.c \
! objfiles.c osabi.c \
p-exp.y p-lang.c p-typeprint.c p-valprint.c parse.c printcmd.c \
regcache.c reggroups.c remote.c \
scm-exp.c scm-lang.c scm-valprint.c \
--- 529,535 ----
mdebugread.c memattr.c mem-break.c minsyms.c mipsread.c \
nlmread.c \
objc-exp.y objc-lang.c \
! objfiles.c osabi.c observer.c \
p-exp.y p-lang.c p-typeprint.c p-valprint.c parse.c printcmd.c \
regcache.c reggroups.c remote.c \
scm-exp.c scm-lang.c scm-valprint.c \
***************
*** 684,689 ****
--- 684,690 ----
ns32k_tdep_h = ns32k-tdep.h
objc_lang_h = objc-lang.h
objfiles_h = objfiles.h $(gdb_obstack_h) $(symfile_h)
+ observer_h = observer.h
ocd_h = ocd.h
osabi_h = osabi.h
p_lang_h = p-lang.h
***************
*** 836,842 ****
signals.o \
kod.o kod-cisco.o \
gdb-events.o \
! exec.o bcache.o objfiles.o minsyms.o maint.o demangle.o \
dbxread.o coffread.o coff-pe-read.o elfread.o \
dwarfread.o dwarf2read.o mipsread.o stabsread.o corefile.o \
dwarf2expr.o dwarf2loc.o \
--- 837,843 ----
signals.o \
kod.o kod-cisco.o \
gdb-events.o \
! exec.o bcache.o objfiles.o observer.o minsyms.o maint.o demangle.o \
dbxread.o coffread.o coff-pe-read.o elfread.o \
dwarfread.o dwarf2read.o mipsread.o stabsread.o corefile.o \
dwarf2expr.o dwarf2loc.o \
***************
*** 1969,1974 ****
--- 1970,1976 ----
$(objfiles_h) $(gdb_stabs_h) $(target_h) $(bcache_h) $(gdb_stat_h) \
$(gdb_obstack_h) $(gdb_string_h) $(breakpoint_h) $(mmalloc_h) \
$(block_h)
+ observer.o: observer.c $(observer_h) $(defs_h)
ocd.o: ocd.c $(defs_h) $(gdbcore_h) $(gdb_string_h) $(frame_h) $(inferior_h) \
$(bfd_h) $(symfile_h) $(target_h) $(gdbcmd_h) $(objfiles_h) \
$(gdb_stabs_h) $(serial_h) $(ocd_h) $(regcache_h)
next reply other threads:[~2003-02-28 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-28 7:34 Joel Brobecker [this message]
2003-02-28 15:19 ` Daniel Jacobowitz
2003-02-28 17:14 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030228073413.GE6112@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox