[RFA] Modify gdb/Makefile.in to build observer.c

Joel Brobecker
2003-02-28T07:34:15Z

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

I made the following changes in order to have observer.[hc] built
in GDB.

Since this unit is currently unused in GDB, I have considered not
linking in this observer.o. However, I think I've seen another recent
patch that is just about ready to benefit from this framework. So I
discarded this idea.

There is one variable that I don't quite understand; it's
HFILES_NO_SRCDIR. The comment ("Header files that need to have srcdir
added", sic) did not help me, so I wasn't sure that observer.h does
not need to be added to this list. Let me know if it should.

2003-02-27 J. Brobecker <brobecker@gnat.com>

* Makefile.in: Add rules to build and link in observer.o.

Ok to apply?
--
Joel

[-- Attachment #2: Makefile.in.diff --]
[-- Type: text/plain, Size: 2174 bytes --]

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.335
diff -c -3 -r1.335 Makefile.in
*** Makefile.in 21 Feb 2003 15:24:17 -0000 1.335
--- Makefile.in 28 Feb 2003 07:24:16 -0000
***************
*** 529,535 ****
mdebugread.c memattr.c mem-break.c minsyms.c mipsread.c \
nlmread.c \
objc-exp.y objc-lang.c \
! objfiles.c osabi.c \
p-exp.y p-lang.c p-typeprint.c p-valprint.c parse.c printcmd.c \
regcache.c reggroups.c remote.c \
scm-exp.c scm-lang.c scm-valprint.c \
--- 529,535 ----
mdebugread.c memattr.c mem-break.c minsyms.c mipsread.c \
nlmread.c \
objc-exp.y objc-lang.c \
! objfiles.c osabi.c observer.c \
p-exp.y p-lang.c p-typeprint.c p-valprint.c parse.c printcmd.c \
regcache.c reggroups.c remote.c \
scm-exp.c scm-lang.c scm-valprint.c \
***************
*** 684,689 ****
--- 684,690 ----
ns32k_tdep_h = ns32k-tdep.h
objc_lang_h = objc-lang.h
objfiles_h = objfiles.h $(gdb_obstack_h) $(symfile_h)
+ observer_h = observer.h
ocd_h = ocd.h
osabi_h = osabi.h
p_lang_h = p-lang.h
***************
*** 836,842 ****
signals.o \
kod.o kod-cisco.o \
gdb-events.o \
! exec.o bcache.o objfiles.o minsyms.o maint.o demangle.o \
dbxread.o coffread.o coff-pe-read.o elfread.o \
dwarfread.o dwarf2read.o mipsread.o stabsread.o corefile.o \
dwarf2expr.o dwarf2loc.o \
--- 837,843 ----
signals.o \
kod.o kod-cisco.o \
gdb-events.o \
! exec.o bcache.o objfiles.o observer.o minsyms.o maint.o demangle.o \
dbxread.o coffread.o coff-pe-read.o elfread.o \
dwarfread.o dwarf2read.o mipsread.o stabsread.o corefile.o \
dwarf2expr.o dwarf2loc.o \
***************
*** 1969,1974 ****
--- 1970,1976 ----
$(objfiles_h) $(gdb_stabs_h) $(target_h) $(bcache_h) $(gdb_stat_h) \
$(gdb_obstack_h) $(gdb_string_h) $(breakpoint_h) $(mmalloc_h) \
$(block_h)
+ observer.o: observer.c $(observer_h) $(defs_h)
ocd.o: ocd.c $(defs_h) $(gdbcore_h) $(gdb_string_h) $(frame_h) $(inferior_h) \
$(bfd_h) $(symfile_h) $(target_h) $(gdbcmd_h) $(objfiles_h) \
$(gdb_stabs_h) $(serial_h) $(ocd_h) $(regcache_h)