Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Michael Elizabeth Chastain <mec@shout.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] gdb_thread_db.h: #errror if no uintptr_t
Date: Wed, 26 Feb 2003 16:59:00 -0000	[thread overview]
Message-ID: <20030226165858.GA13594@nevyn.them.org> (raw)
In-Reply-To: <200302261652.h1QGq0R27186@duracef.shout.net>

On Wed, Feb 26, 2003 at 10:52:00AM -0600, Michael Elizabeth Chastain wrote:
> This patch updates gdb_thread_db.h to die with a more explicit error
> message if HAVE_UINTPTR_T is not defined.  'uintptr_t' is defined in
> glibc 2.1.3 and later.  It might be defined in glibc versions earlier
> than 2.1.3, too, but 2.1.3 is already three years old so I figure that
> is enough.
> 
> Instead of dying, gdb_thread_db.h could substitute some definition
> for uintptr_t.  I chose not to do this because if glibc is that old
> then I don't want to support it anyways.  But a case could be made
> for doing so.
> 
> Note that gdb_thread_db.h is used only on *-*-*linux* and s390-*-*.
> 
> Testing: again, I fiddled with my /usr/include/stdint.h to see both
> code paths.  I also had to disable thread_db.h because my system is
> new enough to actually use this file instead of the copy embedded
> in gdb_thread_db.h.
> 
> This will close PR build/660.
> 
> OK to commit?

> +#error Unable to find uintptr_t type in <stdint.h>.
> +#error Your libc or glibc is too old!
> +#error You must upgrade to glibc 2.1.3 or later.

How about just:
#error No uintptr_t available; your C library is too old.

[This file might be used in non-glibc systems at some point.]

OK with that change.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-02-26 16:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-26 16:52 Michael Elizabeth Chastain
2003-02-26 16:59 ` Daniel Jacobowitz [this message]
2003-02-26 17:19 Michael Elizabeth Chastain
2003-02-26 18:39 ` Joel Brobecker
2003-02-26 18:45   ` Daniel Jacobowitz
2003-02-26 17:31 Michael Elizabeth Chastain
2003-02-26 19:56 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030226165858.GA13594@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec@shout.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox