From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 881 invoked by alias); 26 Feb 2003 16:59:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 871 invoked from network); 26 Feb 2003 16:59:03 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 26 Feb 2003 16:59:03 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18o6mm-0001kS-00; Wed, 26 Feb 2003 13:00:08 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18o4tW-0003YQ-00; Wed, 26 Feb 2003 11:58:58 -0500 Date: Wed, 26 Feb 2003 16:59:00 -0000 From: Daniel Jacobowitz To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa] gdb_thread_db.h: #errror if no uintptr_t Message-ID: <20030226165858.GA13594@nevyn.them.org> Mail-Followup-To: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com References: <200302261652.h1QGq0R27186@duracef.shout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200302261652.h1QGq0R27186@duracef.shout.net> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-02/txt/msg00711.txt.bz2 On Wed, Feb 26, 2003 at 10:52:00AM -0600, Michael Elizabeth Chastain wrote: > This patch updates gdb_thread_db.h to die with a more explicit error > message if HAVE_UINTPTR_T is not defined. 'uintptr_t' is defined in > glibc 2.1.3 and later. It might be defined in glibc versions earlier > than 2.1.3, too, but 2.1.3 is already three years old so I figure that > is enough. > > Instead of dying, gdb_thread_db.h could substitute some definition > for uintptr_t. I chose not to do this because if glibc is that old > then I don't want to support it anyways. But a case could be made > for doing so. > > Note that gdb_thread_db.h is used only on *-*-*linux* and s390-*-*. > > Testing: again, I fiddled with my /usr/include/stdint.h to see both > code paths. I also had to disable thread_db.h because my system is > new enough to actually use this file instead of the copy embedded > in gdb_thread_db.h. > > This will close PR build/660. > > OK to commit? > +#error Unable to find uintptr_t type in . > +#error Your libc or glibc is too old! > +#error You must upgrade to glibc 2.1.3 or later. How about just: #error No uintptr_t available; your C library is too old. [This file might be used in non-glibc systems at some point.] OK with that change. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer