Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nathanael Nerode <neroden@twcny.rr.com>
To: gcc-patches@gcc.gnu.org, binutils@sources.redhat.com,
	gdb-patches@sources.redhat.com, dj@redhat.com
Subject: Toplevel configure.in cleanup 2/n
Date: Tue, 25 Feb 2003 19:20:00 -0000	[thread overview]
Message-ID: <20030225192037.GA1530@doctormoo> (raw)

Only the first change is a behavioral change; this was accidental fallout
from the autoconfiscation.  These 'default' settings now come after argument
processing, which means they override arguments, which is wrong.  The change
restores the intended behavior (they will still default to 'no').

I'll be doing more cleanup passes; I'm breaking them into pieces for ease
of review.  Pass 1/n is the still outstanding change to macroize the 
setting of build_subdir and target_subdir.

Tested on i686-pc-linux-gnu; no change in generated Makefile, unless
--enable-threads or --enable-shared is specified.  (As it should be.)

	* configure.in: Don't set enable_threads and enable_shared to 'no'.
	Remove bogus comments.  Remove redundant noconfigdirs.
	* configure: Regenerate.

--- configure.in.old	2003-02-25 14:04:39.000000000 -0500
+++ configure.in	2003-02-25 14:16:58.000000000 -0500
@@ -27,8 +27,6 @@
 
 # clear some things potentially inherited from environment.
 
-enable_threads=no
-enable_shared=no
 enable_libstdcxx_v3=yes
 floating_point=default
 gas=default
@@ -68,15 +66,6 @@
 
 config_shell=${CONFIG_SHELL-/bin/sh}
 
-## this is a little touchy and won't always work, but...
-##
-## if the argv[[0]] starts with a slash then it is an absolute name that can (and
-## must) be used as is.
-##
-## otherwise, if argv[[0]] has no slash in it, we can assume that it is on the
-## path.  Since PATH might include "." we also add `pwd` to the end of PATH.
-##
-
 progname=$0
 # if PWD already has a value, it is probably wrong.
 if test -n "$PWD" ; then PWD=`${PWDCMD-pwd}`; fi
@@ -418,7 +407,7 @@
     noconfigdirs="$noconfigdirs target-newlib"
     case "${host}" in
       *-*-cygwin*) ;; # keep gdb and readline
-      *) noconfigdirs="$noconfigdirs gdb readline ${libstdcxx_version}"
+      *) noconfigdirs="$noconfigdirs gdb readline"
 	 ;;
     esac
     ;;
@@ -1244,6 +1233,11 @@
   extra_host_args="$extra_host_args --with-newlib"
 fi
 
+# Default to disabling threads.
+case "${enable_threads}" in
+  "") enable_threads=no ;;
+esac
+
 # We default to --with-shared on platforms where -fpic is meaningless.
 # Well, we don't yet, but we will.
 if false && test "${host}" = "${target}" && test x${enable_shared} = x ; then
@@ -1258,7 +1252,7 @@
 case "${enable_shared}" in
   yes) shared=yes ;;
   no) shared=no ;;
-  "") shared=no ;;
+  "") shared=no ; enable_shared=no ;;
   *) shared=yes ;;
 esac
 


             reply	other threads:[~2003-02-25 19:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-25 19:20 Nathanael Nerode [this message]
2003-03-04  5:19 ` Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030225192037.GA1530@doctormoo \
    --to=neroden@twcny.rr.com \
    --cc=binutils@sources.redhat.com \
    --cc=dj@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox