From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30714 invoked by alias); 25 Feb 2003 19:20:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30642 invoked from network); 25 Feb 2003 19:20:51 -0000 Received: from unknown (HELO ms-smtp-03.nyroc.rr.com) (24.92.226.153) by 172.16.49.205 with SMTP; 25 Feb 2003 19:20:51 -0000 Received: from doctormoo (syr-24-24-17-145.twcny.rr.com [24.24.17.145]) by ms-smtp-03.nyroc.rr.com (8.12.5/8.12.2) with ESMTP id h1PJKmbF021528; Tue, 25 Feb 2003 14:20:48 -0500 (EST) Received: from neroden by doctormoo with local (Exim 3.36 #1 (Debian)) id 18nkd3-0000Oj-00; Tue, 25 Feb 2003 14:20:37 -0500 Date: Tue, 25 Feb 2003 19:20:00 -0000 To: gcc-patches@gcc.gnu.org, binutils@sources.redhat.com, gdb-patches@sources.redhat.com, dj@redhat.com Subject: Toplevel configure.in cleanup 2/n Message-ID: <20030225192037.GA1530@doctormoo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i From: Nathanael Nerode X-SW-Source: 2003-02/txt/msg00647.txt.bz2 Only the first change is a behavioral change; this was accidental fallout from the autoconfiscation. These 'default' settings now come after argument processing, which means they override arguments, which is wrong. The change restores the intended behavior (they will still default to 'no'). I'll be doing more cleanup passes; I'm breaking them into pieces for ease of review. Pass 1/n is the still outstanding change to macroize the setting of build_subdir and target_subdir. Tested on i686-pc-linux-gnu; no change in generated Makefile, unless --enable-threads or --enable-shared is specified. (As it should be.) * configure.in: Don't set enable_threads and enable_shared to 'no'. Remove bogus comments. Remove redundant noconfigdirs. * configure: Regenerate. --- configure.in.old 2003-02-25 14:04:39.000000000 -0500 +++ configure.in 2003-02-25 14:16:58.000000000 -0500 @@ -27,8 +27,6 @@ # clear some things potentially inherited from environment. -enable_threads=no -enable_shared=no enable_libstdcxx_v3=yes floating_point=default gas=default @@ -68,15 +66,6 @@ config_shell=${CONFIG_SHELL-/bin/sh} -## this is a little touchy and won't always work, but... -## -## if the argv[[0]] starts with a slash then it is an absolute name that can (and -## must) be used as is. -## -## otherwise, if argv[[0]] has no slash in it, we can assume that it is on the -## path. Since PATH might include "." we also add `pwd` to the end of PATH. -## - progname=$0 # if PWD already has a value, it is probably wrong. if test -n "$PWD" ; then PWD=`${PWDCMD-pwd}`; fi @@ -418,7 +407,7 @@ noconfigdirs="$noconfigdirs target-newlib" case "${host}" in *-*-cygwin*) ;; # keep gdb and readline - *) noconfigdirs="$noconfigdirs gdb readline ${libstdcxx_version}" + *) noconfigdirs="$noconfigdirs gdb readline" ;; esac ;; @@ -1244,6 +1233,11 @@ extra_host_args="$extra_host_args --with-newlib" fi +# Default to disabling threads. +case "${enable_threads}" in + "") enable_threads=no ;; +esac + # We default to --with-shared on platforms where -fpic is meaningless. # Well, we don't yet, but we will. if false && test "${host}" = "${target}" && test x${enable_shared} = x ; then @@ -1258,7 +1252,7 @@ case "${enable_shared}" in yes) shared=yes ;; no) shared=no ;; - "") shared=no ;; + "") shared=no ; enable_shared=no ;; *) shared=yes ;; esac