Re: [rfa] delete lookup_symbol_aux_minsyms

[Daniel Jacobowitz <drow@mvista.com>]

On Sat, Feb 22, 2003 at 11:54:40AM -0800, David Carlton wrote:
> So what's the conclusion?  Performance considerations don't seem to
> give a clear answer.  So we should go with whatever's cleanest.  My
> recommendation:
> 
> * Delete the 'else' clause: it might cause correctness problems.
> 
> * Comment out the remaining part of lookup_symbol_aux_minsyms: if
>   somebody comes up with a situation where we spend lots of time
>   searching for functions that aren't in a loaded symtab, we can
>   consider uncommenting it and adding it back in.

I'm pretty sure the answer is "none at all" based on skimming the code,
but what affect does removing lookup_symbol_aux_minsyms have when
looking for something which turns out not to have debugging info? 
lookup_symbol would fail, so it doesn't matter - is that right?

I don't know if I like this comment-out-part-delete-part business; if
we don't want the function, let's kill it.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer