From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30604 invoked by alias); 22 Feb 2003 21:23:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30576 invoked from network); 22 Feb 2003 21:23:10 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 22 Feb 2003 21:23:10 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18mj06-0006UQ-00; Sat, 22 Feb 2003 17:24:10 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18mgb5-0006ej-00; Sat, 22 Feb 2003 15:50:11 -0500 Date: Sat, 22 Feb 2003 21:23:00 -0000 From: Daniel Jacobowitz To: David Carlton Cc: gdb-patches@sources.redhat.com, Elena Zannoni , Jim Blandy Subject: Re: [rfa] delete lookup_symbol_aux_minsyms Message-ID: <20030222205011.GA25494@nevyn.them.org> Mail-Followup-To: David Carlton , gdb-patches@sources.redhat.com, Elena Zannoni , Jim Blandy References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-02/txt/msg00546.txt.bz2 On Sat, Feb 22, 2003 at 11:54:40AM -0800, David Carlton wrote: > So what's the conclusion? Performance considerations don't seem to > give a clear answer. So we should go with whatever's cleanest. My > recommendation: > > * Delete the 'else' clause: it might cause correctness problems. > > * Comment out the remaining part of lookup_symbol_aux_minsyms: if > somebody comes up with a situation where we spend lots of time > searching for functions that aren't in a loaded symtab, we can > consider uncommenting it and adding it back in. I'm pretty sure the answer is "none at all" based on skimming the code, but what affect does removing lookup_symbol_aux_minsyms have when looking for something which turns out not to have debugging info? lookup_symbol would fail, so it doesn't matter - is that right? I don't know if I like this comment-out-part-delete-part business; if we don't want the function, let's kill it. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer