Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Cc: Jim Blandy <jimb@redhat.com>
Subject: Re: [drow@mvista.com: Re: RFA: LOC_COMPUTED support]
Date: Fri, 21 Feb 2003 17:19:00 -0000	[thread overview]
Message-ID: <20030221171941.GB910@gnat.com> (raw)
In-Reply-To: <20030221152420.GA32260@nevyn.them.org>

> > I think I found some switches that still need LOC_COMPUTED{,_ARG} cases:
> > - ada-lang.c (ada_resolve_subexp, symtab_for_sym,
> >     ada_add_block_symbols, fill_in_ada_prototype) 
> 
> OK, what's up with that?  The code bits in ada_resolve_subexp all
> appear to be commented out.  Is this code going away?

Just from the top of my head, since I haven't directly been involved
with the process of getting this file in: I think they are commented
out until we can add the different pieces that would make them
compilable and/or activatable. 

They will for sure be re-examined when we activate this code.

> symtab_for_sym is pretty hokey too.  All the Ada code reads like
> someone wanted to keep changes local to ada-lang.c when they were
> addressing general symtab weaknesses.  I hope it can all go away
> someday.  The amount of duplication is pretty scary, too.

I don't know the history of this code, Paul Hilfinger will probably know
more, but I agree that getting rid of this code one day would be a
tremendous improvement.

Thanks for taking care of ada-lang.c in the interim. If any problem
arises with the maintenance of these file, please let me and Paul know,
we'll jump in to help.

-- 
Joel


  parent reply	other threads:[~2003-02-21 17:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20030213211157.GA13537@nevyn.them.org>
2003-02-20 23:08 ` Jim Blandy
2003-02-21 15:24   ` Daniel Jacobowitz
2003-02-21 17:08     ` Andrew Cagney
2003-02-21 17:14       ` Daniel Jacobowitz
2003-02-21 17:22         ` Andrew Cagney
2003-02-21 17:19     ` Joel Brobecker [this message]
2003-02-24  3:30 Michael Elizabeth Chastain
2003-02-24  4:15 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030221171941.GB910@gnat.com \
    --to=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox